[jbosstools-issues] [JBoss JIRA] (JBIDE-23136) Deploy Docker Wizard: Pushing image to CDK registry results in an image with no tag

[Dmitrii Bocharov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13323863#comment-13323863 ] 

Dmitrii Bocharov commented on JBIDE-23136:
------------------------------------------

[~mlabuda] [~jeffmaury] it's strange but seems to be an intended behavior. See comments in PushImageToRegistryJob here: https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/dockerutils/PushImageToRegistryJob.java#L76 :
{quote}
// first, we need to tag the image with the OpenShift target project
...
// then we can push that image with the new name
...
*// we need to untag the image, even if the push operation failed*
{quote}

It's made in [this PR|https://github.com/jbosstools/jbosstools-openshift/pull/1201] by [~xcoulon]. [~xcoulon], may i ask you to glance at this jira, please ? Is it really an issue or was made intentionally? 

> Deploy Docker Wizard: Pushing image to CDK registry results in an image with no tag
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-23136
>                 URL: https://issues.jboss.org/browse/JBIDE-23136
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.1.Final
>            Reporter: Marián Labuda
>            Assignee: Dmitrii Bocharov
>              Labels: deploy_docker_wizard, openshift_v3
>             Fix For: 4.4.x
>
>         Attachments: eap64-basic-s2i-new-app-from-cli-1.png, eap64-basic-s2i-new-app-from-jbosstools-1.png, local-docker-images-after-pull-1.png
>
>
> I have a docker connection to local docker daemon and a CDK docker connection. I am pushing an image from a docker connection to CDK registry via Deploy Image to OpenShift wizard. Push of an image pass, but it results into an image with no tag, see:
> 172.30.192.49:5000/msa/msa         <none>      238200ae067d        4 months ago        1.05 GB
> Such images are not shown in docker explorer under a docker connection because of upstream bug ERT-411
> Steps to reproduce:
> - have a project with a file named {{Dockerfile}} with the following content (1 line):
> {code}
> FROM fedora:latest
> {code}
> - Select the file in the project explorer, then {{Run As > Docker Image Build}}. Use the CDK connection and give it a name (eg: {{username/fedora}})
> - Select the image in the Docker Explorer view, then {{Deploy to OpenShift}}. 
> - In the wizard, select the option to push the image to the registry (add a dummy port if needed)
> - once the operation completed, there's an unexpected image named like {{172.30.164.33:5000/<project>/fedora}} in the output of the {{docker images}} command (in CLI)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)