[jbosstools-issues] [JBoss JIRA] (JBIDE-23514) Server adapter: adapters for non-java app should not have a JMX child (double clicking it causes error)

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13330474#comment-13330474 ] 

Rob Stryker commented on JBIDE-23514:
-------------------------------------

[~adietish] We 100% need to get an API to describe what the openshift apps are. We need to an API for basic qualities about it, like whether it's java-based, whether it can expose debug ports, what type of deployment behavior it needs (ie does it need .dodeploy marker or not), etc. 

There are a whole bunch of usecases here where the logic for an openshift adapter needs to know what it's referencing. Lots of behavior could change based on this. 

> Server adapter: adapters for non-java app should not have a JMX child (double clicking it causes error)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23514
>                 URL: https://issues.jboss.org/browse/JBIDE-23514
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.2.AM3
>            Reporter: Andre Dietisheim
>              Labels: jmx, openshift_v3, server_adapter
>             Fix For: 4.4.3.AM1
>
>         Attachments: jmx-error-nodejs.png
>
>
> Most likely server adapters for non-java based apps should not have a jmx node.
> Steps to reproduce:
> 	# ASSERT: make sure that you have a nodejs app (with a service) running in OpenShift (ex. created via nodejs-example template) 
> # ASSERT: make sure the build is finished, the pod is running. 
> # ASSERT: make sure that you have a server adapter for your service 
> # ASSERT: make sure that it is in "[Started, Synchronized]" state) 
> # EXEC: unfold the server adapter and double click on the JMX child 
> Result: 
> An error shows up 
> !jmx-error-nodejs.png! 
> {code} 
> java.io.IOException: org.jolokia.client.exception.J4pRemoteException: Service Unavailable 
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:328) 
> at org.jboss.tools.openshift.core.server.OpenshiftJMXConnectionProvider$1.verifyServerReachable(OpenshiftJMXConnectionProvider.java:83)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:111) 
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29) 
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71) 
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) 
> Caused by: org.jolokia.client.exception.J4pRemoteException: Service Unavailable at org.jolokia.client.J4pClient.extractJsonResponse(J4pClient.java:278) 
> at org.jolokia.client.J4pClient.execute(J4pClient.java:191) 
> at org.jolokia.client.J4pClient.execute(J4pClient.java:168) 
> at org.jolokia.client.J4pClient.execute(J4pClient.java:117) 
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:315) 
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)