[jbosstools-issues] [JBoss JIRA] (JBIDE-23380) MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency

Ilya Buziuk (JIRA) issues at jboss.org
Thu Oct 20 06:31:00 EDT 2016 

    [ https://issues.jboss.org/browse/JBIDE-23380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13309707#comment-13309707 ] 

Ilya Buziuk commented on JBIDE-23380:
-------------------------------------

Not sure if this is connected with this issue but I can not build jbosstools-openshift via vanilla "clean verify":

{code}
[INFO] jbosstools-openshift ............................... SUCCESS [  2.690 s]
[INFO] openshift.plugins .................................. SUCCESS [  0.041 s]
[INFO] org.jboss.tools.openshift.egit.core ................ SUCCESS [ 25.366 s]
[INFO] org.jboss.tools.openshift.egit.ui .................. SUCCESS [  3.055 s]
[INFO] org.jboss.tools.openshift.express.client ........... SUCCESS [ 16.112 s]
[INFO] org.jboss.tools.openshift.common.core .............. SUCCESS [  7.867 s]
[INFO] org.jboss.tools.openshift.express.core ............. SUCCESS [  6.720 s]
[INFO] org.jboss.tools.openshift.common.ui ................ SUCCESS [ 27.254 s]
[INFO] org.jboss.tools.openshift.express.ui ............... SUCCESS [ 13.835 s]
[INFO] org.jboss.tools.openshift.client ................... FAILURE [  1.593 s]
[INFO] org.jboss.tools.openshift.core ..................... SKIPPED
[INFO] org.jboss.tools.openshift.ui ....................... SKIPPED
[INFO] org.jboss.tools.openshift.cdk.server ............... SKIPPED
[INFO] openshift.tests .................................... SKIPPED
[INFO] org.jboss.tools.openshift.egit.test ................ SKIPPED
[INFO] org.jboss.tools.openshift.express.test ............. SKIPPED
[INFO] org.jboss.tools.openshift.test ..................... SKIPPED
[INFO] org.jboss.tools.openshift.cdk.server.test .......... SKIPPED
[INFO] openshift.features ................................. SKIPPED
[INFO] org.jboss.tools.openshift.feature .................. SKIPPED
[INFO] org.jboss.tools.openshift.test.feature ............. SKIPPED
[INFO] org.jboss.tools.openshift.egit.integration.feature . SKIPPED
[INFO] org.jboss.tools.openshift.egit.integration.test.feature SKIPPED
[INFO] org.jboss.tools.openshift.express.feature .......... SKIPPED
[INFO] org.jboss.tools.openshift.express.test.feature ..... SKIPPED
[INFO] org.jboss.tools.openshift.cdk.feature .............. SKIPPED
[INFO] org.jboss.tools.openshift.cdk.test.feature ......... SKIPPED
[INFO] openshift.site ..................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:27 min
[INFO] Finished at: 2016-10-20T12:27:46+02:00
[INFO] Final Memory: 123M/749M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (core-has-ui-deps) on project org.jboss.tools.openshift.client: Execution core-has-ui-deps of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed. NullPointerException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (core-has-ui-deps) on project org.jboss.tools.openshift.client: Execution core-has-ui-deps of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution core-has-ui-deps of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
Caused by: java.lang.NullPointerException
	at org.jboss.tools.releng.CoreUIDependency.findAllDependencies(CoreUIDependency.java:123)
	at org.jboss.tools.releng.CoreUIDependency.createModel(CoreUIDependency.java:73)
	at org.jboss.tools.releng.CoreUIDependency.createModel(CoreUIDependency.java:68)
	at org.jboss.tools.releng.CoreUIDependency.execute(CoreUIDependency.java:45)
	at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:193)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	... 21 more
[ERROR] 
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :org.jboss.tools.openshift.client

{code}

I have updated parent and base bit this does not help :/

> MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency
> ---------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23380
>                 URL: https://issues.jboss.org/browse/JBIDE-23380
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.4.2.AM3
>
>
> At a minimum, the mojo should:
>   foreach plugin, if plugin ends in .core, check plugin/META-INF/MANIFEST for Dependencies manifest header, and verify .ui is not included in the dependencies at all. 
> However, this minimum goal would not have solved the issue we are experiencing with foundation.checkup.  The foundation.checkup plugin does not end in .core and so would be skipped by this simple algorithm. 
> So... we may wish to check transitive dependencies *only in the same repo*.  For example,  foundation.core depends on foundation.checker,  and foundation.checker is in the same repo, so foundation.checker should also be checked for ui deps or fail. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)

More information about the jbosstools-issues mailing list