[jbosstools-issues] [JBoss JIRA] (JBIDE-23380) MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13309845#comment-13309845 ] 

Andre Dietisheim edited comment on JBIDE-23380 at 10/20/16 9:31 AM:
--------------------------------------------------------------------

and yes, this change made openshift go red in jenkins, too. Started on the 20th (today), see [#1623|https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Master/job/jbosstools-openshift_master/1623/]. 
The actual error is an NPE in the mojo:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (core-has-ui-deps) on project org.jboss.tools.openshift.client: Execution core-has-ui-deps of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed. NullPointerException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (core-has-ui-deps) on project org.jboss.tools.openshift.client: Execution core-has-ui-deps of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution core-has-ui-deps of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed.
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
Caused by: java.lang.NullPointerException
	at org.jboss.tools.releng.CoreUIDependency.findAllDependencies(CoreUIDependency.java:123)
	at org.jboss.tools.releng.CoreUIDependency.createModel(CoreUIDependency.java:73)
	at org.jboss.tools.releng.CoreUIDependency.createModel(CoreUIDependency.java:68)
	at org.jboss.tools.releng.CoreUIDependency.execute(CoreUIDependency.java:45)
	at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:193)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	... 21 more
[ERROR] 
[ERROR]
{code}
Happy we reverted. Build is back to the expected.



was (Author: adietish):
and yes, this change made openshift go red in jenkins, too. Started on the 20th (today), see [#1623|https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Master/job/jbosstools-openshift_master/1623/]. Happy we reverted.

> MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency
> ---------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23380
>                 URL: https://issues.jboss.org/browse/JBIDE-23380
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.4.2.AM3
>
>
> At a minimum, the mojo should:
>   foreach plugin, if plugin ends in .core, check plugin/META-INF/MANIFEST for Dependencies manifest header, and verify .ui is not included in the dependencies at all. 
> However, this minimum goal would not have solved the issue we are experiencing with foundation.checkup.  The foundation.checkup plugin does not end in .core and so would be skipped by this simple algorithm. 
> So... we may wish to check transitive dependencies *only in the same repo*.  For example,  foundation.core depends on foundation.checker,  and foundation.checker is in the same repo, so foundation.checker should also be checked for ui deps or fail. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)