[jbosstools-issues] [JBoss JIRA] (JBIDE-23380) MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13310004#comment-13310004 ] 

Nick Boldt commented on JBIDE-23380:
------------------------------------

Looks like the NPE is fixed - can run this new enforcer for all of openshift and it passes.

Problem was here: https://github.com/jbosstools/jbosstools-maven-plugins/commit/fe5f2942136d347bf55612584657dafbfd1e645c?w=1

But the enforcer is completely missing one big chunk of functionality: we're not checking Import-Package declarations, only Require-Bundle. [~rob.stryker] can you add that?

> MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency
> ---------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23380
>                 URL: https://issues.jboss.org/browse/JBIDE-23380
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.4.2.AM3
>
>
> At a minimum, the mojo should:
>   foreach plugin, if plugin ends in .core, check plugin/META-INF/MANIFEST for Dependencies manifest header, and verify .ui is not included in the dependencies at all. 
> However, this minimum goal would not have solved the issue we are experiencing with foundation.checkup.  The foundation.checkup plugin does not end in .core and so would be skipped by this simple algorithm. 
> So... we may wish to check transitive dependencies *only in the same repo*.  For example,  foundation.core depends on foundation.checker,  and foundation.checker is in the same repo, so foundation.checker should also be checked for ui deps or fail. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)