[jbosstools-issues] [JBoss JIRA] (JBIDE-23380) MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13310056#comment-13310056 ] 

Nick Boldt commented on JBIDE-23380:
------------------------------------

Create 7 issues for central, common, cdi, visual-page-editor-core, hibernate, webservices, server with:

{code}
# create console log summary files
# run in a given jbosstools-* git checkout folder
p=$(pwd); p=${p##*/}; mvn clean install -DskipTests | tee ~/Screenshots/${p}-log.txt && cat ~/Screenshots/${p}-log.txt | egrep -B1 "\[CoreUIDependency\]|    > " | grep -v "failed" | tee ~/Screenshots/${p}-log-coreui.txt

# rename console log files to match JIRA component names (as required, eg., for vpe => visual-page-editor-core

# create JIRAs
for c in central common cdi visual-page-editor-core \
hibernate webservices server; do \
file="$(cat ~/Screenshots/coreui/jbosstools-$\{c}-log-coreui.txt)"; \
python createTaskJIRAs.py -u USER -p PWD  -s https://issues.stage.jboss.org \
-i 4.4.2.AM3 -d 10.2.0.AM3 \
-t "UI dependencies from Core plugins" \
-f "The following core plugins depend on UI plugins directly or indirectly. \{code\}$\{file\}\{code\}" \
-c $\{c} -A; \
done
{code}

> MOJO that fails or logs errors for build if manifest in .core plugin has .ui dependency
> ---------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23380
>                 URL: https://issues.jboss.org/browse/JBIDE-23380
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.4.2.AM3
>
>
> At a minimum, the mojo should:
>   foreach plugin, if plugin ends in .core, check plugin/META-INF/MANIFEST for Dependencies manifest header, and verify .ui is not included in the dependencies at all. 
> However, this minimum goal would not have solved the issue we are experiencing with foundation.checkup.  The foundation.checkup plugin does not end in .core and so would be skipped by this simple algorithm. 
> So... we may wish to check transitive dependencies *only in the same repo*.  For example,  foundation.core depends on foundation.checker,  and foundation.checker is in the same repo, so foundation.checker should also be checked for ui deps or fail. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)