[jbosstools-issues] [JBoss JIRA] (JBIDE-23413) use Import-Package instead of Require-Bundle for slf4j.api [hibernate]

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13311706#comment-13311706 ] 

Nick Boldt edited comment on JBIDE-23413 at 10/25/16 2:37 PM:
--------------------------------------------------------------

Possible PR: https://github.com/jbosstools/jbosstools-hibernate/pull/120

However, I can't seem to make all the hibernate tests pass locally. So not sure if this is a better/worse thing. 

{code}
[INFO] org.hibernate.eclipse .............................. SUCCESS [  1.710 s]
...
[INFO] org.hibernate.eclipse.feature ...................... FAILURE [  0.564 s]
...
[INFO] org.hibernate.eclipse.console.test ................. FAILURE [01:40 min]
{code}

Also, seems like you only depend on 2 classes in the whole bundle - both for logging. So you might not need to import all three packages. 

Perhaps you only need a PR like this one?

https://github.com/jbosstools/jbosstools-livereload/pull/134/files


was (Author: nickboldt):
Possible PR: https://github.com/jbosstools/jbosstools-hibernate/pull/120

However, I can't seem to make all the hibernate tests pass locally. So not sure if this is a better/worse thing. 

{code}
[INFO] org.hibernate.eclipse .............................. SUCCESS [  1.710 s]
...
[INFO] org.hibernate.eclipse.feature ...................... FAILURE [  0.564 s]
...
[INFO] org.hibernate.eclipse.console.test ................. FAILURE [01:40 min]
{code}


> use Import-Package instead of Require-Bundle for slf4j.api [hibernate]
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-23413
>                 URL: https://issues.jboss.org/browse/JBIDE-23413
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: hibernate, rpm
>    Affects Versions: 4.4.2.AM2
>            Reporter: Nick Boldt
>            Assignee: Koen Aers
>            Priority: Blocker
>             Fix For: 4.4.2.AM3
>
>         Attachments: org.hibernate.eclipse.unresolved.req.txt
>
>
> Because hibernate tools use Require-Bundle instead of Import-Package to depend on slf4j.api, this project cannot use the rhel implementation (rh-common-java rpm) version of slf4j.api 1.7.4 .jar when installed via rpm on rhel/fedora.
> Here's the line that is causing the problem:
> https://github.com/jbosstools/jbosstools-hibernate/blob/master/plugins/org.hibernate.eclipse/META-INF/MANIFEST.MF#L34
> We need to switch to using Import-Package to that *any* implementation of this package, regardless of *Bundle-SymbolicName*, can be used.
> More info in  JBDS-4136 
> See also:
> http://stackoverflow.com/questions/13959891/why-do-we-need-imported-packages-when-we-have-required-plug-ins-in-eclipse-p
> http://stackoverflow.com/questions/1865819/when-should-i-use-import-package-and-when-should-i-use-require-bundle



--
This message was sent by Atlassian JIRA
(v7.2.2#72004)