[jbosstools-issues] [JBoss JIRA] (JBIDE-23418) Deploy image wizard: "Services and Routing Settings" page creates erroneous first port if all ports are removed

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13312736#comment-13312736 ] 

Viacheslav Kabanovich commented on JBIDE-23418:
-----------------------------------------------

[~adietish], please take a look at the pull request.
The fix initializes port in the same way as when other ports are available.
The 1 / 0 issue is a trick played by the spinner, though I do not see another bug here than the missed initialization: in new ServicePortAdapter, int port = 0, the spinner is customized to show only values >= 1, but displaying 1, it does not change value 0 in the model, the model is modified only on user's input. There is no validation prohibiting 0, but it is ok because the spinner does not let user to set value out of range, just the initial value should be valid.

> Deploy image wizard: "Services and Routing Settings" page creates erroneous first port if all ports are removed
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23418
>                 URL: https://issues.jboss.org/browse/JBIDE-23418
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.2.AM2
>            Reporter: Andre Dietisheim
>         Attachments: all-ports-removed.png, service-port-0.png, service-port-1-pod-port-empty.png
>
>




--
This message was sent by Atlassian JIRA
(v7.2.2#72004)