[jbosstools-issues] [JBoss JIRA] (JBIDE-23413) use Import-Package instead of Require-Bundle for slf4j.api [hibernate]

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13313477#comment-13313477 ] 

Nick Boldt edited comment on JBIDE-23413 at 10/28/16 10:39 AM:
---------------------------------------------------------------

Thanks, I've kicked your job so it'll aggregate down into devstudio.

Currently I'm getting this error when running the latest RPM (before this fix):

{code}
org.osgi.framework.BundleException: Could not resolve module: org.hibernate.eclipse [974]
  Unresolved requirement: Require-Bundle: org.slf4j.api; bundle-version="1.7.2"

... then several errors like this one ...

org.osgi.framework.BundleException: Could not resolve module: org.jboss.tools.hibernate.ui [1069]
  Unresolved requirement: Require-Bundle: org.hibernate.eclipse; bundle-version="5.0.0"
    -> Bundle-SymbolicName: org.hibernate.eclipse; bundle-version="5.1.2.v20160915-1030"; singleton:="true"
       org.hibernate.eclipse [974]
         Unresolved requirement: Require-Bundle: org.slf4j.api; bundle-version="1.7.2"
  Unresolved requirement: Require-Bundle: org.hibernate.eclipse.console; bundle-version="5.0.0"
    -> Bundle-SymbolicName: org.hibernate.eclipse.console; bundle-version="5.1.2.v20160926-1506"; singleton:="true"
       org.hibernate.eclipse.console [975]
         Unresolved requirement: Require-Bundle: org.hibernate.eclipse; bundle-version="5.0.0"
           -> Bundle-SymbolicName: org.hibernate.eclipse; bundle-version="5.1.2.v20160915-1030"; singleton:="true"
{code}


was (Author: nickboldt):
Thanks, I've kicked your job so it'll aggregate down into devstudio.

Currently I'm getting this error when running the latest RPM (before this fix):

{code}
org.osgi.framework.BundleException: Could not resolve module: org.hibernate.eclipse [974]
  Unresolved requirement: Require-Bundle: org.slf4j.api; bundle-version="1.7.2"
then
org.osgi.framework.BundleException: Could not resolve module: org.jboss.tools.hibernate.ui [1069]
  Unresolved requirement: Require-Bundle: org.hibernate.eclipse; bundle-version="5.0.0"
    -> Bundle-SymbolicName: org.hibernate.eclipse; bundle-version="5.1.2.v20160915-1030"; singleton:="true"
       org.hibernate.eclipse [974]
         Unresolved requirement: Require-Bundle: org.slf4j.api; bundle-version="1.7.2"
  Unresolved requirement: Require-Bundle: org.hibernate.eclipse.console; bundle-version="5.0.0"
    -> Bundle-SymbolicName: org.hibernate.eclipse.console; bundle-version="5.1.2.v20160926-1506"; singleton:="true"
       org.hibernate.eclipse.console [975]
         Unresolved requirement: Require-Bundle: org.hibernate.eclipse; bundle-version="5.0.0"
           -> Bundle-SymbolicName: org.hibernate.eclipse; bundle-version="5.1.2.v20160915-1030"; singleton:="true"
{code}

> use Import-Package instead of Require-Bundle for slf4j.api [hibernate]
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-23413
>                 URL: https://issues.jboss.org/browse/JBIDE-23413
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: hibernate, rpm
>    Affects Versions: 4.4.2.AM2
>            Reporter: Nick Boldt
>            Assignee: Koen Aers
>            Priority: Blocker
>             Fix For: 4.4.2.AM3
>
>         Attachments: org.hibernate.eclipse.unresolved.req.txt
>
>
> Because hibernate tools use Require-Bundle instead of Import-Package to depend on slf4j.api, this project cannot use the rhel implementation (rh-common-java rpm) version of slf4j.api 1.7.4 .jar when installed via rpm on rhel/fedora.
> Here's the line that is causing the problem:
> https://github.com/jbosstools/jbosstools-hibernate/blob/master/plugins/org.hibernate.eclipse/META-INF/MANIFEST.MF#L34
> We need to switch to using Import-Package to that *any* implementation of this package, regardless of *Bundle-SymbolicName*, can be used.
> More info in  JBDS-4136 
> See also:
> http://stackoverflow.com/questions/13959891/why-do-we-need-imported-packages-when-we-have-required-plug-ins-in-eclipse-p
> http://stackoverflow.com/questions/1865819/when-should-i-use-import-package-and-when-should-i-use-require-bundle



--
This message was sent by Atlassian JIRA
(v7.2.2#72004)