[jbosstools-issues] [JBoss JIRA] (JBIDE-23178) cdk tools not reading / closing process streams correctly

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294782#comment-13294782 ] 

Rob Stryker commented on JBIDE-23178:
-------------------------------------

To be clear what was happening here:

Old code was launching the process, and then waiting for the process to terminate before reading the streams. This was incorrect behavior. Once the stream's buffer filled up, the process cannot die until it can finish its output. Meanwhile my code was refusing to read the streams until the process died. 

Logic was very backwards. It should be fixed with PR https://github.com/jbosstools/jbosstools-openshift/pull/1314

> cdk tools not reading / closing process streams correctly
> ---------------------------------------------------------
>
>                 Key: JBIDE-23178
>                 URL: https://issues.jboss.org/browse/JBIDE-23178
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.4.1.Final
>            Reporter: Rob Stryker
>
> Calls to environment manager or vagrant status often fail with a timeout. Sometimes they can be worked around, so the user never sees the error. However the implementation is incorrect. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)