[jbosstools-issues] [JBoss JIRA] (JBIDE-23039) Need an interactive terminal that fits specific requirements

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294785#comment-13294785 ] 

Rob Stryker commented on JBIDE-23039:
-------------------------------------

Hi Hardy:

We were definitely setting the vagrant_detected_os environment variable every time. It was always there. The problem was that if we didn't also pass a SUB_USERNAME and SUB_PASSWORD, the registration plugin would try to prompt us to enter them... and vagrant as a whole has no way to prompt users without using a TTY solution. 

The error is thrown from vagrant / ruby directly, and it's because the registration plugin asked them to prompt us and they had no way to do it. 

The solution that I've found now is to use some code in eclipse cdt (c++ dev tools) which can create a PTY (pseudo-tty) to wrap every command we run in windows.  There is a downside to it though:  it adds color codes to EVERY command run (even a simple java TestClass).  Yes, I know VAGRANT_NO_COLOR is a valid environment variable ;)  The problem is the PTY lib is adding the color codes, not vagrant. 

So My new patch  (https://github.com/jbosstools/jbosstools-openshift/pull/1312)  makes sure to only use the cdt pty solution when we're presenting stuff to the user in a terminal, but for our calls to vagrant status or vagrant service-manager, we use the old Runtime.getRuntime().exec(etc). 

THis still has the very small potential to fail if in the future we ever make vagrant status or vagrant service-manager prompt the user or use tty functionality... but that is extremely unlikely. 

So I think the newest patch is the best and it seems to work in all cases (with a small UI problem in mac, but, I mean, mac's weird).  

> Need an interactive terminal that fits specific requirements
> ------------------------------------------------------------
>
>                 Key: JBIDE-23039
>                 URL: https://issues.jboss.org/browse/JBIDE-23039
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: server
>    Affects Versions: 4.4.1.AM2
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.4.2.AM1
>
>         Attachments: vagranttty.png
>
>
> CDK Tools requires a terminal that allows interactivity of i/o. The full set of requirements is a bit difficult to find a solution for. 
> 1) I must be able to get a Process or IProcess object when a command is run
> 2) I must be able to get an event or know when the process terminates
> 3) The terminal or console must be interactive and allow user input when prompted. 
> 4) It must behave as in 3) for 'vagrant' commands and any and all associated plugins. 
> These three requirements thus far seem impossible to solve. Solutions that have been attempted are:
> 1) Creating a java Process by myself via Runtime.exec.  The interactive prompts never arrive and there is no API for Process to know when it is waiting for input. 
> 2) Using the external-tools launch configuration. When running a command like mvn, the console that pops up seems to allow input from the user, and functions as expected. However, when running a command such as vagrant, such prompts are not provided. In our usecase, the following behavior is observed:
>    a) During vagrant-registration prompts, the console indicates it is not a TTY terminal and cannot allow input
>    b) During a landrush prompt for superuser status, no prompt is made, no TTY message is listed, and the process appears to have frozen
> 3) Launching / Opening a tm.terminal view.  This solution fails requirements 1 and 2.  We are not able to get a Process or an IProcess when a command is launched in a proper interactive terminal. This means we can have no way to know when the process has completed. 
> Other options have been explored but ended up at dead ends and not worth mentioning. The real question is why interactive behavior is visible when using external-tools launch config for maven, but is not visible when running vagrant. 
> Is this a function of the way the vagrant commands display or prompt for input? Why does vagrant-registration require a TTY terminal, but maven does not? Is this something that can be fixed upstream? 
> No other obvious solutions have presented themselves in the past year. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)