[jbosstools-issues] [JBoss JIRA] (JBIDE-23159) Bump plugin/feature/component versions in main branch when creating branches for Final/GA release

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295394#comment-13295394 ] 

Nick Boldt commented on JBIDE-23159:
------------------------------------

No, it does NOT do the upversioning because every project is different. Some keep all the plugins/features aligned, some use a mix of 1.x, 2.x, 3.x, and 4.x plugins. Also, we don't blindly upversion just because we've branched. We only upversion where it makes sense. 

Sometimes we upversion from x.y.z to x.y.z+1. Sometimes we upversion to x.y.z+99 (eg., to move to 4.3.100 while 4.3.1 is in the maintenance branch). And sometimes, we move to x.y+1.0 (eg., from 1.1.1 to 1.2.0) because bigger changes are planned as we move to a new version of Eclipse. I would expect this to be true of Openshift as it depends on Docker Tools, and Docker Tools will be moving up to a x.y+1 version in Neon.1.

I can't script all those rules since they vary by project (and sometimes by subproject too) so I leave it to the component leads to know when/how to upversion correctly, using the script noted in the generated JIRAs:

{code}
mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:0.25.0:set-version -DnewVersion=1.0.1-SNAPSHOT
{code}

There's also the baseline comparison check that will fail when devs forget to upversion. But it won't tell them HOW to upversion, only that the version needs to be greater than the baseline, which is currently set to jbosstools 4.4.1.Final. So if a project like Openshift forgets to bump from 3.3.0 to 3.3.1, and ends up trying to build 3.3.0.AM1 when 3.3.0.Final is in the baseline, it'll complain:

{code}
[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:0.26.0:compare-version-with-baselines (default) on project org.jboss.tools.openshift.client: Version have moved backwards for (org.jboss.tools.openshift.client/3.3.0.AM1-v20160917-1037-B1568). Baseline has 3.3.0.Final-v20160902-1639-B14) with delta: 0.0.0 -> [Help 1]
{code} -- https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Master/job/jbosstools-openshift_master/1568/console

> Bump plugin/feature/component versions in main branch when creating branches for Final/GA release 
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23159
>                 URL: https://issues.jboss.org/browse/JBIDE-23159
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Alexey Kazakov
>            Assignee: Nick Boldt
>             Fix For: 4.4.2.AM1
>
>
> The script which creates branches for a Final/GA release when codefreezing should also bump plugin/feature/component versions in main branch (master or maintenance).
> The script should probably have a parameter which tells what segment of the version we want to increment: X.Y.Z



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)