[jbosstools-issues] [JBoss JIRA] (JBIDE-23208) SSLCertificatesPreference.isValid(String): Could not parse

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296643#comment-13296643 ] 

Viacheslav Kabanovich commented on JBIDE-23208:
-----------------------------------------------

The date is stored in preferences by X509CertificateParser where it is converted from Date to String by getValidity(X509Certificate). 
The validity of dates retrieved from preferences is checked in SSLCertificatesPreference.isValid(String).
These methods match until default Locale is changed on computer. The problem can be fixed by explicitely setting in both these places English locale:
{code}
	SimpleDateFormat dateFormat = new SimpleDateFormat(X509CertificateParser.DATE_FORMAT, Locale.ENGLISH);
{code}
However, to provide for the backword compatibility, the check SSLCertificatesPreference.isValid(String) should for a couple of versions try both default and English locales.


> SSLCertificatesPreference.isValid(String): Could not parse
> ----------------------------------------------------------
>
>                 Key: JBIDE-23208
>                 URL: https://issues.jboss.org/browse/JBIDE-23208
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, openshift
>    Affects Versions: 4.4.2.AM1
>            Reporter: Martin Malina
>
> When I start CDK and OpenShift connection is established, I get this in the Error Log view:
> org.jboss.tools.openshift.ui
> SSLCertificatesPreference.isValid(String): Could not parse 'Čt, 20 Zář 2018 12:54:07' in format E, d MMM yyyy HH:mm:ss
> An exception stack trace is not available.
> As you can see, the date is localized. I think this started happening after I updated to macOS Sierra last night - I never noticed it before. If we can figure out where the parsing is happening, perhaps we can come up with a switch for using english date here.
> Env:
> devstudio-10.2.0.AM1-v20160920-0457-B6061-installer-standalone.jar
> cdk 2.2.rc5



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)