[jbosstools-issues] [JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys are hard-coded, not read from docker image

[Andre Dietisheim (JIRA)]

Andre Dietisheim created JBIDE-24184:
----------------------------------------

             Summary: Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys are hard-coded, not read from docker image
                 Key: JBIDE-24184
                 URL: https://issues.jboss.org/browse/JBIDE-24184
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: openshift
    Affects Versions: 4.4.4.AM2
            Reporter: Andre Dietisheim


to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:

* nodejs
{code}
"Labels": {
                ...
                "com.redhat.dev-mode": "DEV_MODE:false",
                "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
                ...
{code}
* eap
{code}
"Labels": {
                ...
               "com.redhat.dev-mode": "DEBUG:true",
                "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
                ...
{code}

Our code on the other hand is hard-coding these, not reading the keys from the docker image:
{code}
public class OpenShiftDebugUtils {
   private static final String DEBUG_KEY = "DEBUG";
   private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
   ...
{code}
{code}
public class OpenShiftLaunchController extends AbstractSubsystemController
		implements ISubsystemController, ILaunchServerController {
    ...
    private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
    ...
{code}




--
This message was sent by Atlassian JIRA
(v7.2.3#72005)