[jbosstools-issues] [JBoss JIRA] (JBIDE-24236) cdk3 oc command

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13392597#comment-13392597 ] 

Andre Dietisheim edited comment on JBIDE-24236 at 4/11/17 5:46 PM:
-------------------------------------------------------------------

Great idea, really. 
In the preferences, where one does set the location of the oc binary we look up the PATH if the location is not set. See here: https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/preferences/OpenShiftPreferencePage.java#L114
As you pointed out we might have to store oc binaries per connection, but only if it turns out that oc is not backward compatible (would oc 3.4 work with CDK 2.3?). As far as I remember there were problems. Verifying this is for sure the first step to take. If that's not true, or the vast exception, I'd tend to think that we can simply also look up the cache for minishift beside the PATH.
A simple warning for known compat issues in specific oc binaries could also help keeping this simple using single, global oc location (see here where we warn that oc < 1.1.1 is not working for rsync: https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/preferences/OpenShiftPreferencePage.java#L195)


was (Author: adietish):
Great idea, really. 
In the preferences, where one does set the location of the oc binary we look up the PATH if the location is not set. See here: https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/preferences/OpenShiftPreferencePage.java#L114
As you pointed out we might have to store oc binaries per connection, but only if it turns out that oc is not backward compatible (would oc 3.4 work with CDK 2.3?). As far as I remember there were problems. Verifying this is for sure the first step to take. If that's not true, or the vast exception, I'd tend to think that we can simply also look up the cache for minishift beside the PATH.
A simple warning for known compat issues in specific oc binaries could also help keeping this simple using single, global oc location (see here where we warn that oc < 1.1.1 is not working for rsync: https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/preferences/OpenShiftPreferencePage.java#L195)

> cdk3 oc command
> ---------------
>
>                 Key: JBIDE-24236
>                 URL: https://issues.jboss.org/browse/JBIDE-24236
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, openshift
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>
> After minishift setup-cdk,  the oc command is at    %USERPROFILE%\.minishift\cache\oc\v3.4.1.2
> Should our tools help streamline this process for users? I would suggest yes, but needs investigation **how** to do it. 
> Another question is, do we need different 'oc' command versions for each openshift connection? Should it really be a workplace setting? Or should it be per-connection? 



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)