[jbosstools-issues] [JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444045#comment-13444045 ] 

Andre Dietisheim commented on JBIDE-24797:
------------------------------------------

[~dbocharov] [~jeffmaury] [~rob.stryker] as discussed yesterday

> Code formatter: define and hook code formatting enforcement for github PRs
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-24797
>                 URL: https://issues.jboss.org/browse/JBIDE-24797
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.5.0.Final
>            Reporter: Andre Dietisheim
>             Fix For: 4.5.1.AM1
>
>
> Code formatting differs across developers. 
> The most prominent differences I am aware of are
> * use spaces vs tabs
> * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#diff-2aee3d4adef72e336d1730c1427a38a0L179] :
> {code}
> if(XX){
> {code}
> vs
> {code}
> if (XX) {
> {code}
> * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#diff-51a43116dc03db69ba28ae6aa212b932L242]
> * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#diff-2aee3d4adef72e336d1730c1427a38a0R234]
> {code}
>              class Listener {
> int i = 0;
>  public void method()        {
>              }
>    }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)