[jbosstools-issues] [JBoss JIRA] (JBIDE-24796) Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project

[Martin Malina (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447248#comment-13447248 ] 

Martin Malina commented on JBIDE-24796:
---------------------------------------

[~rob.stryker]:
{quote}
I finally realized that the bug you are mentioning is that if you open the server editor, change the minishift_home, save it, close editor, re-open it, then it still shows the old value.
{quote}
I actually didn't know about this bug, but you're right - I just tried and that's happening.
{quote}
And if you modify, save, and open the launch config, the env variable isn't overridden with the new value.
{quote}
Yes, that's correct. I guess this is caused by the previous thing. But to be clear, there is no MINISHIFT_HOME env var set at all.

Let me try the patch.

> Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-24796
>                 URL: https://issues.jboss.org/browse/JBIDE-24796
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, openshift
>    Affects Versions: 4.5.0.Final
>         Environment: Fedora
>            Reporter: Ondrej Dockal
>            Assignee: Rob Stryker
>            Priority: Critical
>         Attachments: cdk3_sa-manual_correct-mhome.png, cdk3_sa-manual_wrong-mhome2.png
>
>
> In the first case I would understand that if you change you minishift home (in server editor) and then you start server adapter, you will get some mess... Although, I would like to see a validation of minishift home here. We are checking minishit binary, why not to check minishift home (in this case for existence of the folder). See 
> !cdk3_sa-manual_wrong-mhome2.png|thumbnail! 
> In the second case comes the bug. Even if I have set MINISHIFT_HOME folder, called setup-cdk that configured everything in that folder and put this folder as Minishift Home, CDK3 Server Adapter is not respecting that location. Or it is maybe OS tooling, not sure here. Solution here would be a check that verifies minishift's home set in CDK server editor corresponds with the one that minishift binary uses, if it is possible (from the side of binary) - but that seems not to be an option here as minishift/cdk stored everything in config that resides in MINISHIFT_HOME or ~/.minishift folder. See
>  !cdk3_sa-manual_correct-mhome.png|thumbnail! 
> Cc: [~adietish] [~rob.stryker].



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)