[jbosstools-issues] [JBoss JIRA] (JBIDE-24802) Connection wizard: Lots of unnecessary errors in Error Log when filling oc location, Finish enabled even if oc location empty

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451026#comment-13451026 ] 

Rob Stryker commented on JBIDE-24802:
-------------------------------------

[~mmalina] I cannot replicate this. My error log is clean. What's more, looking at the code, we don't even attempt to run the oc -version command if the file doesn't exist:

{code}
    		if (StringUtils.isBlank(location)) {
    			error = "OC Location cannot be empty";
    		} else {
        		File file = new File(location);
        		// Error messages have to be set to field editor, not directly to the
        		// page.
        		if (!file.exists()) {
        			error = (NLS.bind("{0} was not found.", file));
        		} else if (!file.canExecute()) {
        			error = (NLS.bind("{0} does not have execute permissions.", file));
        		}
    		}
    		
    		if( error == null ) {
    			version = new OCBinaryVersionValidator(location).getVersion(monitor);
    		}
            if (monitor.isCanceled()) {
            	return Status.CANCEL_STATUS;
            }
            return Status.OK_STATUS;
        }
{code}

Am I using the wrong UI?

> Connection wizard: Lots of unnecessary errors in Error Log when filling oc location, Finish enabled even if oc location empty
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-24802
>                 URL: https://issues.jboss.org/browse/JBIDE-24802
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.5.0.Final
>            Reporter: Radim Hopp
>            Assignee: Rob Stryker
>            Priority: Minor
>              Labels: connection_wizard, openshift_v3
>             Fix For: 4.5.x
>
>         Attachments: Spectacle.F10835.png
>
>
> On-the-fly validation of "oc location" field in ConnectionWizardPage puts lot of errors into error log. I think that the on the fly validation should not be so agressive.
> !Spectacle.F10835.png!
> And another thing: Is there any reason why Finish is enabled even when there is not valid value in oc location field?



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)