[jbosstools-issues] [JBoss JIRA] (JBIDE-24783) Update default registry url for cdk 3

[Martin Malina (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452977#comment-13452977 ] 

Martin Malina commented on JBIDE-24783:
---------------------------------------

I wanted to verify this and when I use a simple wrapper around minishift to break this (i.e. print "bla bla" for minishift openshift registry), openshift connection then has "http://bla bla" set up as the registry.

But it looks like I don't have the commit yet:
org.jboss.tools.openshift.cdk.server_3.4.1.v20170822-2117.jar
I'll have to wait for a new build of devstudio.

But this brings a question:
[~rob.stryker], what will trigger the error message? From the code it seems that as long as the command returns something, you will use it. Unless there is an IOException which I'm not sure when that would happen. Shouldn't you at least check the validity of the url? Because it seems that right now you will happily take any string at all, even if it's a message saying there is no url.

> Update default registry url for cdk 3
> -------------------------------------
>
>                 Key: JBIDE-24783
>                 URL: https://issues.jboss.org/browse/JBIDE-24783
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, openshift
>    Affects Versions: 4.5.0.AM2
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>             Fix For: 4.5.1.AM1
>
>
> Yesterday I started cdk 3 and it seemed to start ok, but was not really ok.
> The registry command didn't really work:
> {code}
> $ ./minishift openshift registry
> No information found for 'service/docker-registry'
> {code}
> The result is that the openshift connection details showed this under Image Registry URL:
> https://hub.openshift.rhel-cdk.10.1.2.2.xip.io
> This seems like the default value for cdk 2. I think we should update the default value for cdk 3. Or is this simply a default value for an openshift connection? In any case, this should use the cdk 3 value.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)