[jbosstools-issues] [JBoss JIRA] (JBIDE-24868) Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455390#comment-13455390 ] 

Andre Dietisheim edited comment on JBIDE-24868 at 8/29/17 9:06 AM:
-------------------------------------------------------------------

If I get things right changing the router timeout seems non-available to the non-admin user. 
Then it seems as if we could forward the ports from the ports directly (not connecting via the router). I believe that this is what we're doing currently: {code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/behavior/OpenShiftLaunchController.java#L360}
		Set<PortPair> podPorts = PortForwardingUtils.getForwardablePorts(pod);
{code}
So far I believe that we're not affected by the timeout in the router. But then, it this scenario there's apparently a timeout in the port-forwaring, too, as discussed here: https://issues.jboss.org/browse/JBIDE-23422?focusedCommentId=13334141&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13334141. In arquillian they add a keep-alive ping, something we cannot do since we use oc to forward the ports and thus are not in control of that socket. I believe that we should reach out to openshift for advice how to tackle this since it makes debugging pretty useless.
[~rhuss] [~jeffmaury] [~aurelien.pupier] Thoughts? 

ps. there's a blog by the openshift team how to debug using oc which basically shows what we do behind the scenes: https://blog.openshift.com/debugging-java-applications-on-openshift-kubernetes/


was (Author: adietish):
If I get things right changing the router timeout seems non-available to the non-admin user. 
Then it seems as if we could forward the ports from the ports directly (not connecting via the router). I believe that this is what we're doing currently: {code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/behavior/OpenShiftLaunchController.java#L360}
		Set<PortPair> podPorts = PortForwardingUtils.getForwardablePorts(pod);
{code}
So far I believe that we're not affected by the timeout in the router. But then, it this scenario there's apparently a timeout in the port-forwaring, too, as discussed here: https://issues.jboss.org/browse/JBIDE-23422?focusedCommentId=13334141&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13334141. In arquillian they add a keep-alive ping, something we cannot do since we use oc to forward the ports and thus are not in control of that socket. I believe that we should reach out to openshift for advice how to tackle this since it makes debugging pretty useless.
[~rhuss] [~jeffmaury] [~aurelien.pupier] Thoughts? 

> Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-24868
>                 URL: https://issues.jboss.org/browse/JBIDE-24868
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>            Reporter: Aurélien Pupier
>            Assignee: Andre Dietisheim
>            Priority: Critical
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.5.x
>
>
> it will avoid to have "debug connections always killed after 30s staying in a breakpoint"
> see https://twitter.com/ro14nd/status/895886024387067904 for source of suggestion
> k8 documentations on the matter are here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)