[jbosstools-issues] [JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs
Dmitrii Bocharov (JIRA)
issues at jboss.org
Thu Aug 31 10:17:01 EDT 2017
[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456994#comment-13456994 ]
Dmitrii Bocharov commented on JBIDE-24797:
------------------------------------------
I don't see a problem in installing a formatter into IDE. All big projects do it, it's a common stuff in software development and it's kind of our "must do" daily routine. As a result it would help to avoid talks about formatting once and forever.
[~adietish] yes, this plugin offers just checks (without formatting) - see README on the main page of the plugin repository: https://github.com/coveo/fmt-maven-plugin#standard-pomxml
> Code formatter: define and hook code formatting enforcement for github PRs
> --------------------------------------------------------------------------
>
> Key: JBIDE-24797
> URL: https://issues.jboss.org/browse/JBIDE-24797
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: devdoc, hibernate, openshift, server
> Affects Versions: 4.5.0.Final
> Reporter: Andre Dietisheim
> Assignee: Dmitrii Bocharov
> Fix For: 4.5.1.AM2
>
>
> Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons.
> The most prominent differences I am aware of are
> * use spaces vs tabs
> * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#diff-2aee3d4adef72e336d1730c1427a38a0L179]):
> {code}
> if(XX){
> {code}
> vs
> {code}
> if (XX) {
> {code}
> * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#diff-51a43116dc03db69ba28ae6aa212b932L242]:
> {code}
> public void method() {
> int i = 0;
> i++;
> i +=2;
> {code}
> * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#diff-2aee3d4adef72e336d1730c1427a38a0R234]
> {code}
> class Listener {
> int i = 0;
> public void method() {
> }
> }
> {code}
> * multiple empty lines for no obvious reason like shown [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#diff-01c4863bc31948052342aedc6a09d290L87]
> {code}
> public class ZZ {
> int i = 0;
> i++
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
More information about the jbosstools-issues
mailing list