[jbosstools-issues] [JBoss JIRA] (JBIDE-18743) [release] Testing: write tests for download.jboss.org & devstudio.redhat.com xmlunit test cases; validate composite*.xml; *.properties validation -- check if all properties are defined (avoid boss.* vs. jboss.*)

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505254#comment-13505254 ] 

Nick Boldt edited comment on JBIDE-18743 at 12/13/17 4:03 PM:
--------------------------------------------------------------

I've updated https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/validateCompositeSiteChildrenExist.sh to do better checking and support a -fn flag to report all the 404s instead of stopping on the first one. It can now be run against a set of URLs, too.

So rather than using p2browser and parsing the log, we can run this against a set of URLs to validate, and use the console log parser to report any problems.

Then I forked that file to make its output  cleaner and support recursion:

https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/validateCompositeSites.sh

Here's a job-in-progress we can enhance to parse the ide-config.properrties file, so that all the composite sites are validated.

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/jbosstools-releng/job/jbosstools-releng-push-to-staging-00-validate-composites/

I've already found one broken URL:

{code}
$➔ ./validateCompositeSites.sh http://download.jboss.org/jbosstools/oxygen/development/updates/integration-stack/discovery/earlyaccess/

[INFO] Checking for valid children in: http://download.jboss.org/jbosstools/oxygen/development/updates/integration-stack/discovery/earlyaccess//compositeContent.xml

{1/1} [1/1] http://download.jboss.org/jbosstools/oxygen/development/updates/integration-stack/discovery/earlyaccess//../4.5.1.Beta1b/earlyaccess : NO 

[INFO] URLs found: 0
[ERROR] URLs missing: 1
{code}



was (Author: nickboldt):
I've updated https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/validateCompositeSiteChildrenExist.sh to do better checking and support a -fn flag to report all the 404s instead of stopping on the first one. It can now be run against a set of URLs, too.

So rather than using p2browser and parsing the log, we can run this against a set of URLs to validate, and use the console log parser to report any problems.

Here's a job-in-progress we can enhance to parse the ide-config.properrties file, so that all the composite sites are validated.

Then I forked that file to make its output  cleaner and support recursion:

https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/validateCompositeSites.sh

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/jbosstools-releng/job/jbosstools-releng-push-to-staging-00-validate-composites/

I've already found one broken URL:

{code}
$➔ ./validateCompositeSites.sh http://download.jboss.org/jbosstools/oxygen/development/updates/integration-stack/discovery/earlyaccess/

[INFO] Checking for valid children in: http://download.jboss.org/jbosstools/oxygen/development/updates/integration-stack/discovery/earlyaccess//compositeContent.xml

{1/1} [1/1] http://download.jboss.org/jbosstools/oxygen/development/updates/integration-stack/discovery/earlyaccess//../4.5.1.Beta1b/earlyaccess : NO 

[INFO] URLs found: 0
[ERROR] URLs missing: 1
{code}


> [release] Testing: write tests for download.jboss.org & devstudio.redhat.com xmlunit test cases; validate composite*.xml; *.properties validation -- check if all properties are defined (avoid boss.* vs. jboss.*)
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-18743
>                 URL: https://issues.jboss.org/browse/JBIDE-18743
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>    Affects Versions: 4.2.0.Final
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.5.2.AM3
>
>
> We need to write tests for download.jboss.org & devstudio.redhat.com:
> * xmlunit test cases
> ** validate composite*.xml
> ** unit testing for discovery plugin.xml, update site category.xml (avoid bad URLs like 8.0-staging in a milestone release)
> * other test cases
> ** \*.properties validation -- check if all properties are defined (avoid boss.* vs. jboss.*)



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)