[jbosstools-issues] [JBoss JIRA] (JBIDE-23961) Server adapter: "Start/Restart in Debug" is broken for Nodejs

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13365101#comment-13365101 ] 

Andre Dietisheim edited comment on JBIDE-23961 at 2/16/17 6:50 PM:
-------------------------------------------------------------------

The cause for this is the following:
In JBIDE-22362 we always enabled DEV_MODE.  When launching the debugger one finds the following code that checks if the debugging is enabled:
{code:title=OpenShiftDebugUtils#getDebuggingContext}
		debugContext.setDebugEnabled(Boolean.parseBoolean(debugEnabled) || Boolean.parseBoolean(devModeEnabled));
{code}
Thus when the server adapter starts the debugger he erroneously thinks that debugging is already active and wont reenable it. 

The following change *FIXES* it, the debugger is started correctly, no port error happens. 
{code}
		debugContext.setDebugEnabled(Boolean.parseBoolean(debugEnabled));
{code}

But I'm very unsure about the side-effects. Maybe this now is only true for nodejs and will affect eap, too. 


was (Author: adietish):
The cause for this is the following:
In JBIDE-22362 we always enabled DEV_MODE.  When launching the debugger one finds the following code that checks if the debugging is enabled:
{code:title=OpenShiftDebugUtils#getDebuggingContext}
		debugContext.setDebugEnabled(Boolean.parseBoolean(debugEnabled) || Boolean.parseBoolean(devModeEnabled));
{code}
Thus when the server adapter starts the debugger he erroneously thinks that debugging is already active and wont reenable it. 
changing it to 
{code}
		debugContext.setDebugEnabled(Boolean.parseBoolean(debugEnabled));
{code}

But I'm very unsure about the side-effects. Maybe this now is only true for nodejs and will affect eap, too. 

> Server adapter: "Start/Restart in Debug" is broken for Nodejs
> -------------------------------------------------------------
>
>                 Key: JBIDE-23961
>                 URL: https://issues.jboss.org/browse/JBIDE-23961
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.3.Final
>            Reporter: Andre Dietisheim
>            Priority: Critical
>         Attachments: image-2017-02-16-23-30-21-709.png, server-adapter-erroneous-debugging-state.png
>
>




--
This message was sent by Atlassian JIRA
(v7.2.3#72005)