[jbosstools-issues] [JBoss JIRA] (JBIDE-23900) Refactor OpenShift server adapter to isolate EAP/Wildfly and NodeJS specific stuff

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13370063#comment-13370063 ] 

Andre Dietisheim commented on JBIDE-23900:
------------------------------------------

Among other issues there is duplication of code where the environment variables are set:

{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/behavior/OpenShiftLaunchController.java#L211}
deploymentConfig.setEnvironmentVariable(DEV_MODE_KEY, String.valueOf(debugContext.isDebugEnabled()));
{code}

is duplicate to

{code:title=https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/internal/core/server/debug/OpenShiftDebugUtils.java#L184}
dc.setEnvironmentVariable(DEV_MODE, Boolean.TRUE.toString());
{code}


> Refactor OpenShift server adapter to isolate EAP/Wildfly and NodeJS specific stuff
> ----------------------------------------------------------------------------------
>
>                 Key: JBIDE-23900
>                 URL: https://issues.jboss.org/browse/JBIDE-23900
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.3.Final
>            Reporter: Jeff MAURY
>            Assignee: Dmitrii Bocharov
>             Fix For: 4.4.4.AM1
>
>
> We should isolate EAP/Wildfly and NodeJS specific stuff for the server adapter into separate classes / extensions
> We should also provide a mechanism for the sever adapter to be stack agnostic so that we can add more stacks by just addding an extension
> This will be probably required by FUSE integration



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)