[jbosstools-issues] [JBoss JIRA] (JBIDE-23668) Move integration-tests parent pom configuration to jbosstools-build/parent/pom.xml

[Jeff MAURY (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13343706#comment-13343706 ] 

Jeff MAURY commented on JBIDE-23668:
------------------------------------

The general pattern about moving those tests into component repo is that:
* they should run against the current installation
* they should follow existing test configurations
* if they run for a longer period, they should be moved to a specific common profile
*
Based on that, I think the only relevant property to be moved is integrationTestsSystemProperties and may be merged with common test properties.
The surefire timeout must be part of this specific common profile
Idem for the profiles because they seem to be linked to tests running with DevStudio which is not our case anymore

> Move integration-tests parent pom configuration to jbosstools-build/parent/pom.xml
> ----------------------------------------------------------------------------------
>
>                 Key: JBIDE-23668
>                 URL: https://issues.jboss.org/browse/JBIDE-23668
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build, integration-tests
>            Reporter: Pavol Srna
>            Assignee: Jeff MAURY
>             Fix For: 4.4.3.AM2
>
>
> This configuration needs to be moved from [1] to build/parent/pom.xml
> {code}
> <properties>
> 	<surefire.timeout>7200</surefire.timeout>		
> 	<integrationTestsSystemProperties>-Dusage_reporting_enabled=false</integrationTestsSystemProperties>
> 	<devstudio.repository>https://devstudio.redhat.com/10.0/snapshots/updates/</devstudio.repository>
> 	<testProduct>com.jboss.devstudio.core.product</testProduct>
> </properties>
> {code}
> {code}
> <profile>
> 	<id>mac-installPath</id>
> 	<activation>
> 		<os>
> 			<family>mac</family>
> 		</os>
> 	</activation>
> 	<properties>
> 		<test.installPath.OSX>/devstudio.app/Contents/Eclipse/</test.installPath.OSX>
> 	</properties>
> </profile>
> 		<profile>
> 			<id>install-base</id>
> 			<activation>
> 				<property>
> 					<name>test.installBase</name>
> 				</property>
> 			</activation>
> 			<properties>
> 				<test.installPath>${test.installBase}${test.installPath.OSX}</test.installPath>
> 			</properties>
> 			<build>
> 				<plugins>
> 					<plugin>
> 						<groupId>org.eclipse.tycho</groupId>
> 						<artifactId>tycho-surefire-plugin</artifactId>
> 						<configuration>
> 							<work>${test.installPath}</work>
> 							<product>${testProduct}</product>
> 						</configuration>
> 					</plugin>
> 				</plugins>
> 			</build>
> 		</profile>
> 		<profile>
> 			<!-- Workaround for https://bugs.eclipse.org/bugs/show_bug.cgi?id=388084 -->
> 			<id>osx</id>
> 			<activation>
> 				<os>
> 					<family>mac</family>
> 				</os>
> 			</activation>
> 			<properties>
> 				<platformSystemProperties> -XstartOnFirstThread </platformSystemProperties>
> 			</properties>
> 		</profile>
> 		<profile>
> 			<id>download-devstudio</id>
> 			<activation>
> 				<property>
> 					<name>!test.installBase</name>
> 				</property>
> 			</activation>
> 			<build>
> 				<plugins>
> 					<plugin>
> 						<groupId>org.eclipse.tycho</groupId>
> 						<artifactId>tycho-surefire-plugin</artifactId>
> 						<configuration>
> 							<product>${testProduct}</product>
> 						</configuration>
> 					</plugin>
> 					<plugin>
> 						<groupId>org.eclipse.tycho</groupId>
> 						<artifactId>target-platform-configuration</artifactId>
> 						<configuration>
>       							<dependency-resolution>
>            							<extraRequirements>
> 									<requirement>
> 										<type>p2-installable-unit</type>
> 										<id>com.jboss.devstudio.core.feature.feature.group</id>
> 										<versionRange>0.0.0</versionRange>
> 									</requirement>
>          							</extraRequirements>
>     							</dependency-resolution>
> 						</configuration>
> 					</plugin>
> 				</plugins>
> 			</build>
> 			<repositories>
> 				<repository>
> 					<id>devstudio-repo</id>
> 					<name>devstudio-repo</name>
> 					<layout>p2</layout>
> 					<url>${devstudio.repository}</url>
> 				</repository>
> 			</repositories>
> 		</profile>
> {code}
> {code}
> 	<build>
> 		<plugins>
> 			<plugin>
> 				<groupId>org.eclipse.tycho</groupId>
> 				<artifactId>tycho-surefire-plugin</artifactId>
> 				<configuration>
> 					<useUIThread>false</useUIThread>
> 					<appArgLine>-pluginCustomization ${basedir}/../pluginCustomization.ini</appArgLine>
> 					<systemProperties>
> 						<org.eclipse.update.reconcile>false</org.eclipse.update.reconcile>
> 						<!-- JBDS-4077 this should be passed in from Jenkins or commandline -->
> 						<tpc.version>${TARGET_PLATFORM_VERSION_MAX}</tpc.version>
> 					</systemProperties>
> 					<explodedBundles>
> 						<bundle>org.mozilla.xulrunner.cocoa.macosx</bundle>
> 						<bundle>org.mozilla.xulrunner.gtk.linux.x86</bundle>
> 						<bundle>org.mozilla.xulrunner.gtk.linux.x86_64</bundle>
> 						<bundle>org.mozilla.xulrunner.win32.win32.x86</bundle>
> 					</explodedBundles>
> 				</configuration>
> 			</plugin>
> 		</plugins>
> 	</build>
> {code}
> We need to find out how to deal with pluginCustomization.ini [2]. Download from somewhere?
> [1] https://github.com/jbosstools/jbosstools-integration-tests/blob/master/tests/pom.xml
> [2] https://github.com/jbosstools/jbosstools-integration-tests/blob/master/tests/pluginCustomization.ini



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)