[jbosstools-issues] [JBoss JIRA] (JBIDE-23737) Integration test: if symlink to oc exists, but target isnt, OpenShiftCommandLineToolsRequirement is failing

Andre Dietisheim (JIRA) issues at jboss.org
Wed Jan 11 15:23:00 EST 2017


     [ https://issues.jboss.org/browse/JBIDE-23737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim updated JBIDE-23737:
-------------------------------------
    Steps to Reproduce: 
# ASSERT: make sure that there's a symlink on your filesystem jbosstools-integration-tests/tests/org.jboss.tools.openshift.ui.bot.test/binaries/oc that points to a non-existing file
# EXEC: launch some integration test that has the @OCBinary annotation (ex. PortForwardingTest)

Result:
The test will fail complaining that the symlink cannot be created because it already exists.
{code}
org.jboss.tools.openshift.reddeer.exception.OpenShiftToolsException: Could not symlink /Users/adietish/Documents/jboss-workspaces/jbosstools-integration-tests/tests/org.jboss.tools.openshift.ui.bot.test/binaries/oc to /Users/adietish/Documents/jboss-workspaces/jbosstools-integration-tests/tests/org.jboss.tools.openshift.ui.bot.test/binaries/openshift-origin-client-tools-v1.3.2-ac1d579-mac/oc:
java.nio.file.FileAlreadyExistsException: binaries/oc
	at org.jboss.tools.openshift.reddeer.requirement.OpenShiftCommandLineToolsRequirement.createSymlink(OpenShiftCommandLineToolsRequirement.java:77)
	at org.jboss.tools.openshift.reddeer.requirement.OpenShiftCommandLineToolsRequirement.fulfill(OpenShiftCommandLineToolsRequirement.java:66)
	at org.jboss.reddeer.junit.internal.requirement.Requirements.fulfill(Requirements.java:105)
	at org.jboss.reddeer.junit.internal.runner.statement.FulfillRequirementsStatement.evaluate(FulfillRequirementsStatement.java:44)
	at org.jboss.reddeer.junit.internal.runner.statement.RunIBeforeClassExtensions.evaluate(RunIBeforeClassExtensions.java:72)
	at org.jboss.reddeer.junit.internal.runner.statement.RunAfters.evaluate(RunAfters.java:68)
	at org.jboss.reddeer.junit.internal.runner.statement.CleanUpRequirementStatement.evaluate(CleanUpRequirementStatement.java:44)
	at org.jboss.reddeer.junit.internal.runner.statement.RunIAfterClassExtensions.evaluate(RunIAfterClassExtensions.java:59)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.jboss.reddeer.junit.internal.runner.RequirementsRunner.run(RequirementsRunner.java:153)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.jboss.reddeer.eclipse.core.RemotePluginTestRunner.main(RemotePluginTestRunner.java:68)
	at org.jboss.reddeer.eclipse.core.UITestApplication.runTests(UITestApplication.java:125)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Testable$1.run(E4Testable.java:73)
	at java.lang.Thread.run(Thread.java:745)
{code}

  was:
# ASSERT: make sure that there's a symlink on your filesystem jbosstools-integration-tests/tests/org.jboss.tools.openshift.ui.bot.test/binaries/oc that points to a non-existing file
# EXEC: launch some integration test that has the @OCBinary annotation (ex. PortForwardingTest)

Result:
The test will fail complaining that the symlink cannot get created because it already exists.
{code}
org.jboss.tools.openshift.reddeer.exception.OpenShiftToolsException: Could not symlink /Users/adietish/Documents/jboss-workspaces/jbosstools-integration-tests/tests/org.jboss.tools.openshift.ui.bot.test/binaries/oc to /Users/adietish/Documents/jboss-workspaces/jbosstools-integration-tests/tests/org.jboss.tools.openshift.ui.bot.test/binaries/openshift-origin-client-tools-v1.3.2-ac1d579-mac/oc:
java.nio.file.FileAlreadyExistsException: binaries/oc
	at org.jboss.tools.openshift.reddeer.requirement.OpenShiftCommandLineToolsRequirement.createSymlink(OpenShiftCommandLineToolsRequirement.java:77)
	at org.jboss.tools.openshift.reddeer.requirement.OpenShiftCommandLineToolsRequirement.fulfill(OpenShiftCommandLineToolsRequirement.java:66)
	at org.jboss.reddeer.junit.internal.requirement.Requirements.fulfill(Requirements.java:105)
	at org.jboss.reddeer.junit.internal.runner.statement.FulfillRequirementsStatement.evaluate(FulfillRequirementsStatement.java:44)
	at org.jboss.reddeer.junit.internal.runner.statement.RunIBeforeClassExtensions.evaluate(RunIBeforeClassExtensions.java:72)
	at org.jboss.reddeer.junit.internal.runner.statement.RunAfters.evaluate(RunAfters.java:68)
	at org.jboss.reddeer.junit.internal.runner.statement.CleanUpRequirementStatement.evaluate(CleanUpRequirementStatement.java:44)
	at org.jboss.reddeer.junit.internal.runner.statement.RunIAfterClassExtensions.evaluate(RunIAfterClassExtensions.java:59)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.jboss.reddeer.junit.internal.runner.RequirementsRunner.run(RequirementsRunner.java:153)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.jboss.reddeer.eclipse.core.RemotePluginTestRunner.main(RemotePluginTestRunner.java:68)
	at org.jboss.reddeer.eclipse.core.UITestApplication.runTests(UITestApplication.java:125)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Testable$1.run(E4Testable.java:73)
	at java.lang.Thread.run(Thread.java:745)
{code}



> Integration test: if symlink to oc exists, but target isnt, OpenShiftCommandLineToolsRequirement is failing
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23737
>                 URL: https://issues.jboss.org/browse/JBIDE-23737
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: integration-tests, openshift
>    Affects Versions: 4.4.3.AM1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 4.4.3.AM2
>
>




--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jbosstools-issues mailing list