[jbosstools-issues] [JBoss JIRA] (JBIDE-23705) no content assist in freemarker templates for interface-based beans
Ronald Müller (JIRA)
issues at jboss.org
Thu Jan 12 10:28:00 EST 2017
[ https://issues.jboss.org/browse/JBIDE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13347388#comment-13347388 ]
Ronald Müller commented on JBIDE-23705:
---------------------------------------
Thank you for reviewing. My pull request was thought as proposal, not as final implementation. Its running on my maschine now and works so far (at least for me ;-) ). I'm sorry that didn't provide any tests for that, but i'm not familiar with plugin development and have not enough spare time for a deep dive.
Anyway the mentioned class/method should definitly be reviewed. There are serious bugs in there. The reflection part will not run in any case. See line 181 of jbosstools-freemarker/plugins/org.jboss.ide.eclipse.freemarker/src/org/jboss/ide/eclipse/freemarker/model/interpolation/NameFragment.java The condition there will never hold true.
regards ronald
> no content assist in freemarker templates for interface-based beans
> -------------------------------------------------------------------
>
> Key: JBIDE-23705
> URL: https://issues.jboss.org/browse/JBIDE-23705
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Reporter: Ronald Müller
>
> If your beans in freemarker templates are described by an interface, the code completion (content assist) will not work.
> There two mechanism implemented to provide content suggestion:
> # Bean-Introspection: this doesn't work for interfaces
> # Java Reflections: there are bugs which prevent any suggestions
> My suggestion: use only reflections - it will work for both and isn't that harder to implement.
> I'm working on a pull request for fixing this issue.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
More information about the jbosstools-issues
mailing list