[jbosstools-issues] [JBoss JIRA] (JBIDE-23758) Avoid caught NPE in wst StopAction by providing an empty list instead of null

[Aurélien Pupier (JIRA)]

Aurélien Pupier created JBIDE-23758:
---------------------------------------

             Summary: Avoid caught NPE in wst StopAction by providing an empty list instead of null
                 Key: JBIDE-23758
                 URL: https://issues.jboss.org/browse/JBIDE-23758
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: server
    Affects Versions: 4.4.2.Final
            Reporter: Aurélien Pupier


when starting JBDS, there is a silent caught NPE in AsbtractServerAction.selectionChanged because org.jboss.ide.eclipse.as.ui.actions.AbstractServerActionDelegate$4 is returning null instead of an empty list

{noformat}
Thread [main] (Suspended (exception NullPointerException))	
	owns: RunnableLock  (id=138)	
	StopAction(AbstractServerAction).selectionChanged(IStructuredSelection) line: 75	
	StopAction.<init>(Shell, ISelectionProvider) line: 36	
	StopServerActionDelegate.init(IWorkbenchWindow) line: 24	
	WWinPluginAction.initDelegate() line: 187	
	WWinPluginAction(PluginAction).createDelegate() line: 125	
	WWinPluginAction.refreshActionList() line: 167	
	AbstractUIPlugin$1.run() line: 482	
	RunnableLock.run() line: 35	
	UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 182	
	Display.runAsyncMessages(boolean) line: 4203	
	Display.readAndDispatch() line: 3819	
	PartRenderingEngine$4.run() line: 1121	
	Realm.runWithDefault(Realm, Runnable) line: 336	
	PartRenderingEngine.run(MApplicationElement, IEclipseContext) line: 1022	
	E4Workbench.createAndRunUI(MApplicationElement) line: 150	
	Workbench$5.run() line: 687	
	Realm.runWithDefault(Realm, Runnable) line: 336	
	Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 604	
	PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 148	
	IDEApplication.start(IApplicationContext) line: 138	
	EclipseAppHandle.run(Object) line: 196	
	EclipseAppLauncher.runApplication(Object) line: 134	
	EclipseAppLauncher.start(Object) line: 104	
	EclipseStarter.run(Object) line: 388	
	EclipseStarter.run(String[], Runnable) line: 243	
	NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]	
	NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62	
	DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43	
	Method.invoke(Object, Object...) line: 498	
	Main.invokeFramework(String[], URL[]) line: 673	
	Main.basicRun(String[]) line: 610	
	Main.run(String[]) line: 1519	
	Main.main(String[]) line: 1492	
{noformat}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)