[jbosstools-issues] [JBoss JIRA] (JBIDE-23761) ensure that as, runtime test-framework plugins/features are added to the coretests site

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13349068#comment-13349068 ] 

Rob Stryker commented on JBIDE-23761:
-------------------------------------

Since whatever changes you made affected hte jbt-server ball color, I'm going to make some notes here:

Following guide at https://wiki.eclipse.org/Minerva#Source
------------------------

1) sourceTemplateFeature  and gitkeep
   a)  Ran on all folders of as, jmx, wtp, archives. All are already present
2) feature's pom.xml
   a) None of my feature's pom.xmls have this xml, but neither do any of the poms in base features... Assumed to be in parent pom somehow?
3) build.properties of every plugin
   - Cleaned up to make sure all build.properties have a src.includes = * and src.excludes = src
   - This step doesn't really make sense to me. What's the point of excluding the source folder in the source build??
   - See part 6 for some strange stuff about build.properties
4) features added to site.xml?
   - All were already added 
5) Additions to parent pom?
   - Assume done in parent pom already

6) Oddities / plugins that do not conform
   -  jmx.jvmmonitor.core and jmx.jvmmonitor.ui have a very weird structure. 
   - They look as follows:
      source.jvmmonitor-core.jar = src/
      output.jvmmonitor-core.jar = bin/
      bin.includes = [etc etc etc]

   - No idea how to remedy this stuff... they seem to actually include the generated jar in the build somehow? Not sure wtf is going on here. I made no changes here but these are the only two plugins that are 'weird'... 

Running build locally now and will commit if it doesn't seem like it broke anything, then will get jenkins results after

> ensure that as, runtime test-framework plugins/features are added to the coretests site
> ---------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23761
>                 URL: https://issues.jboss.org/browse/JBIDE-23761
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build, server, updatesite
>    Affects Versions: 4.4.3.AM1
>            Reporter: Nick Boldt
>            Assignee: Rob Stryker
>             Fix For: 4.4.3.AM2
>
>
> [7:30 AM] Pavol Srna: @RobStryker hi Rob, got a minute?
> [7:31 AM] Pavol Srna: @RobStryker wondering if the (as, runtime) test-framework can be made available e.g. here: http://download.jboss.org/jbosstools/neon/snapshots/updates/coretests/master/
> [7:31 AM] Pavol Srna: what do you think?
> [7:34 AM] Pavol Srna: I don't see it in the org.jboss.ide.eclipse.as.test.feature on site, maybe needs a rebuild?
> [12:49 PM] Nick Boldt: if you want more test plugins/features in the coretests site... make sure they're part of the server site [1] and then PR me to add them to the coretests site [2].
> [1] http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-server_master/latest/all/repo/
> [2] http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.coretests-site_master/latest/all/repo/
> Submit PR against this:
> https://github.com/jbosstools/jbosstools-build-sites/blob/master/aggregate/coretests-site/category.xml#L50



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)