[jbosstools-issues] [JBoss JIRA] (JBIDE-23769) New Application: Do not throw exception in error log when provided template is of wrong kind.

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13352606#comment-13352606 ] 

Andre Dietisheim edited comment on JBIDE-23769 at 1/24/17 5:43 AM:
-------------------------------------------------------------------

I general having a stacktrace is always a benefit. But here I fully agree with you, this isnt a proper error, it's a user mistake where he's providing the wrong json file. 


was (Author: adietish):
I general having a stacktrace is always a benefit. But here I fully agree with you, this isnt a proper error, this a user error where he's providing the wrong json file.

> New Application: Do not throw exception in error log when provided template is of wrong kind.
> ---------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23769
>                 URL: https://issues.jboss.org/browse/JBIDE-23769
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.3.AM1
>            Reporter: Radim Hopp
>            Priority: Minor
>
> When creating new application from local template one selects wrong file (not of kind "Template", but kind "Pod" for example) multiple (same) exceptions are thrown into error log:
> {noformat}
> !ENTRY org.eclipse.core.databinding 4 0 2017-01-19 13:56:20.472
> !MESSAGE Unhandled exception: Wrong resource kind: Pod
> !STACK 0
> org.jboss.tools.openshift.internal.ui.wizard.newapp.NotATemplateException: Wrong resource kind: Pod
> 	at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizardModel.getLocalAppSource(NewApplicationWizardModel.java:139)
> 	at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizardModel.loadAppSource(NewApplicationWizardModel.java:293)
> 	at org.jboss.tools.openshift.internal.ui.wizard.newapp.ApplicationSourceListPage$17.run(ApplicationSourceListPage.java:824)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {noformat}
> I think it's enough to inform the user in the wizard (this is already happening).



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)