[jbosstools-issues] [JBoss JIRA] (JBIDE-19604) Save Password in New Openshift Application Wizard is annoying

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432666#comment-13432666 ] 

Rob Stryker commented on JBIDE-19604:
-------------------------------------

I've tested the issue. Few things to note:

1) The oxygen builds have a new invisible secure storage provider for linux, so this won't happen. But, for the purposes of completeness, go to the secure storage preference page and disable that. 

2) The current behavior does not match the video. The current behavior is that when trying to move from 1st page to 2nd page, if you have 'save password' checked, it will attempt a secure storage. When you cancel, an error dialog will appear, suggesting you uncheck save password nad continue. 

3) At this point, though, there's still errors. The 'next' button will never activate. It will be enabled, but it will always go to the same (current) page, and never move to a next page.  Whether you uncheck 'save password' or don't... this will no longer move you to a second page. 

So, with my PR, I'd suggest the workflow is fixed. We just make sure the next attempt to press 'next' also validates the connection rather than it falling into a case that's not checked for. 

> Save Password in New Openshift Application Wizard is annoying
> -------------------------------------------------------------
>
>                 Key: JBIDE-19604
>                 URL: https://issues.jboss.org/browse/JBIDE-19604
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.0.Alpha2
>         Environment: Linux, x86_64, Open JDK 7 
>            Reporter: Denis Golovin
>            Assignee: Rob Stryker
>              Labels: openshift_v2
>             Fix For: 4.5.0.AM2
>
>         Attachments: openshif-save-password.mp4
>
>
> Selected "Save Password" option in wizard triggers secure storage login that cannot be canceled in on click. This dialog keeps coming back after Cancel is pressed (three or more times). After reopening wizard first Security Storage Login pops up that I have to Cancel it several times (see attached video).



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)