[jbosstools-issues] [JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435007#comment-13435007 ] 

Andre Dietisheim edited comment on JBIDE-24184 at 7/12/17 8:19 PM:
-------------------------------------------------------------------

There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomment-314738165]. I opted for postponing it to 4.5.0.Final
I could fix a part of it but couldnt resolve the whole issue (launching a server adapter for a freshly created app, that is based on the "nodejs-mongo-persistent" template, fails to start up. It complains that it doesnt find any matching replication controller. Relaunching it once the build is fully finished works fine in my tests. This very fact needs to be confirmed by QE/tester though). 
I also think that it needs more serious testing since there's larger refactoring involved.


was (Author: adietish):
There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomment-314738165]. I could fix a part of it but couldnt for resolve the whole issue. I also think that it needs more serious testing since there's larger refactoring involved. It should get merged as early as possible in the upcoming sprint. Postponing to 4.5.0.Final

> Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-24184
>                 URL: https://issues.jboss.org/browse/JBIDE-24184
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.4.AM2
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.5.0.Final
>
>
> to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:
> * nodejs
> {code}
> "Labels": {
>                 ...
>                 "com.redhat.dev-mode": "DEV_MODE:false",
>                 "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
>                 ...
> {code}
> * eap
> {code}
> "Labels": {
>                 ...
>                "com.redhat.dev-mode": "DEBUG:true",
>                 "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
>                 ...
> {code}
> Our code on the other hand is hard-coding these, not reading the keys from the docker image:
> {code}
> public class OpenShiftDebugUtils {
>    private static final String DEBUG_KEY = "DEBUG";
>    private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
>    ...
> {code}
> {code}
> public class OpenShiftLaunchController extends AbstractSubsystemController
> 		implements ISubsystemController, ILaunchServerController {
>     ...
>     private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
>     ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)