[jbosstools-issues] [JBoss JIRA] (JBIDE-24273) CDK3 server adapter editor: can save editor even if "Minishift Location" is invalid

[Martin Malina (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436765#comment-13436765 ] 

Martin Malina commented on JBIDE-24273:
---------------------------------------

I have a comment about this. I have a few arguments in favor of the old behavior. First is that when I start devstudio for the first time, there will already be a cdk3 adapter created because ~/.minishift was found. But this adapter will have an empty minishift binary location. So you can see that in any case you cannot rely on a valid binary being always set. And secondly, even if a binary is valid at the time of the dialog saving, you can remove or change it at a later time. So in my opinion this does not bring much value - I think the decorator is enough. Furthermore, I don't like the popup. Normally, when you have a validation, usually it's in a dialog where you will just disable the Finish or Next button, but of course that's not an option here.

I just wanted to add my $0.02. I'm not saying that you need to revert this or something.

> CDK3 server adapter editor: can save editor even if "Minishift Location" is invalid
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-24273
>                 URL: https://issues.jboss.org/browse/JBIDE-24273
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.4.4.AM3
>            Reporter: Andre Dietisheim
>            Assignee: Rob Stryker
>             Fix For: 4.5.0.AM2
>
>
> # ASSERT: have a non-executable file ready
> # ASSERT: have a cdk3/minishift server adapter
> # EXEC: open server editor for your cdk3/minishift adapter
> # EXEC: for "Minishift Location" hit "Browse" and choose your non-executable file
> # ASSERT: error decoration appears
> # EXEC: hit "Save"
> Result:
> The server adapter is saved even though the minishift location is erroneous



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)