[jbosstools-issues] [JBoss JIRA] (JBIDE-24682) Reflect changes in minishift's version command

[Ondrej Dockal (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439310#comment-13439310 ] 

Ondrej Dockal commented on JBIDE-24682:
---------------------------------------

[~rob.stryker][~hardy.ferentschik] thanks guys for taking swift action in this issue. I am checking progress and I am ready to test bits right away at the time when they are out (cdk nightly build and Rob's PR reflecting changes in minishift version command.

I am thinking of dedicating one jenkins job base on nightly CDK builds that could be incorporated in CKD nightly build pipeline. [~hardy.ferentschik] You already talked about it on previous meetings and as soon as https://issues.jboss.org/browse/JBIDE-24656 is done, I will be able to provide this hopefully-fast and stable basic smoke test job of cdk integration in devstudio to you and so, we would have end-to-end pipeline for cdk, that would catch such tooling breakages asap.

> Reflect changes in minishift's version command
> ----------------------------------------------
>
>                 Key: JBIDE-24682
>                 URL: https://issues.jboss.org/browse/JBIDE-24682
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.5.0.Final
>            Reporter: Ondrej Dockal
>            Assignee: Rob Stryker
>            Priority: Blocker
>             Fix For: 4.5.0.Final
>
>
> Due to changes in upstream project the 'minishift version' command returns different lines.
> CDK result from http://cdk-builds.usersys.redhat.com/builds/weekly/19-Jun-2017.cdk-3.0.0-CVE-2/ build:
> {code}
> Minishift version: 1.0.0+4f8cb6d
> CDK Version: 3.0.0-2
> {code}
> vs.
> CDK result from nightly  http://cdk-builds.usersys.redhat.com/builds/nightly/13-Jul-2017 build:
> {code}
> minishift v1.2.0+001371f
> CDK Version:3.0.0-13072017-1
> {code}
> And this change results in error while creating CDK 3 server adapter with newer CDK nightly build as it ends with "Unknown error while checking minishift version" as we expect the string to contains "Minishift Version". 
> We should get in touch with cdk team to check whether they plan to change the output 'CDK Version' to something else as well, in case we are going to distinguish between minishift and cdk. If we accept in CDK 3 server adapter both cdk and minishift binary maybe we should create a CDK jira that would ask for changing output from 'minishift version' from 'CDK Version: X.X.X' to 'cdk vX.X.X'.  I do not know if we plan to do so, it is just an idea...



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)