[jbosstools-issues] [JBoss JIRA] (JBIDE-23677) write maven enforcer test to ensure we set correct version of foundation.core (based on parent pom version)

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13372456#comment-13372456 ] 

Nick Boldt commented on JBIDE-23677:
------------------------------------

Quick workaround since I'll be AFK on PTO next week:

https://github.com/jbosstools/jbosstools-base/commit/0022689b29aa4012d71ea639e9b45c0feded311f

A better fix might be to parse the parent pom version rather than the root pom version of jbosstools-base. But then we need to clean it to remove the qualifier/suffix:

{code}
diff --git a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
index d073e4b..20a8cbf 100644
--- a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
+++ b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
@@ -44,7 +44,7 @@
                                                        <goal>parse-version</goal>
                                                </goals>
                                                <configuration>
-                                                       <versionString>${project.parent.parent.parent.version}</versionString>
+                                                       <versionString>${project.parent.parent.parent.parent.version}</versionString>
                                                </configuration>
                                        </execution>
                                </executions>
@@ -87,7 +87,7 @@
                                                <configuration>
                                                        <rules>
                                                                <foundationCoreVersionMatchesParentPom implementation="org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom">
-                                                                       <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase>
+                                                                       <!-- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase> -->
                                                                        <currentVersionProperties>src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties</currentVersionProperties>

==>

[INFO] --- maven-enforcer-plugin:1.4.1:enforce (foundation-core-default-version-check) @ org.jboss.tools.foundation.core ---
[WARNING] Rule 0: org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom failed with message:

[ERROR] Invalid value of default.version = 4.4.4.Final for parent = 4.4.4.AM1.AM1-SNAPSHOT !

Must set default.version = 4.4.4.AM1.Final (or = 4.4.4.AM1.AM1) in this file:

/home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-base/foundation/plugins/org.jboss.tools.foundation.core/src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties

{code}

> write maven enforcer test to ensure we set correct version of foundation.core (based on parent pom version) 
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23677
>                 URL: https://issues.jboss.org/browse/JBIDE-23677
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build, foundation
>    Affects Versions: 4.4.3.AM1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.4.4.AM1, 4.5.0.AM1
>
>
> Wrong version of foundation.core detected. Should be 4.4.3, not 4.4.2.
> https://github.com/jbosstools/jbosstools-base/blob/master/foundation/plugins/org.jboss.tools.foundation.core/src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties#L11



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)