[jbosstools-issues] [JBoss JIRA] (JBIDE-23813) Package Explorer: context menu can cause exception when selected project has svn metadata but erroneously configured/missing SVN provider

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13372901#comment-13372901 ] 

Andre Dietisheim commented on JBIDE-23813:
------------------------------------------

Looking into it in details reveals that this is not propagated to the caller. What we got reported is apparently an Eclipse log entry, no exception is being propaganted to the caller as far as I can see in org.eclipse.team.core 3.8.0.v20170104 as in TP jbosstoolstarget-4.70.0.AM1-SNAPSHOT.
EGitUtils#isShared is calling 
{code:title=EGitUtils.isShared}
RepositoryProvider.getProvider(project)
{code}

which is catching the TeamException:
{code:title=org.eclipse.team.core.RepositoryProvider}
final public static RepositoryProvider getProvider(IProject project, String id) {
	try {
		...
		} catch(CoreException e) {
{code}

> Package Explorer: context menu can cause exception when selected project has svn metadata but erroneously configured/missing SVN provider
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23813
>                 URL: https://issues.jboss.org/browse/JBIDE-23813
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.3.AM1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>              Labels: openshift_v2
>             Fix For: 4.4.4.AM1, 4.5.0.AM1
>
>
> created from aeri. The following stack trace is reported:
> {code}
> Bundle: org.eclipse.team.core 3.7.100.v20150203-1452
> Message: Could not instantiate provider org.tigris.subversion.subclipse.core.svnnature for project pef.client.
> Exception:
> org.eclipse.team.core.TeamException: Could not instantiate provider org.tigris.subversion.subclipse.core.svnnature for project pef.client.
>     at org.eclipse.team.core.RepositoryProvider.mapNewProvider(RepositoryProvider.java:165)
>     at org.eclipse.team.core.RepositoryProvider.mapExistingProvider(RepositoryProvider.java:235)
>     at org.eclipse.team.core.RepositoryProvider.getProvider(RepositoryProvider.java:507)
>     at org.jboss.tools.openshift.egit.core.EGitUtils.isShared(EGitUtils.java:132)
>     at org.jboss.tools.openshift.express.internal.ui.propertytester.ProjectPropertyTester.isIfSharedIsEGit(ProjectPropertyTester.java:48)
>     at org.jboss.tools.openshift.express.internal.ui.propertytester.ProjectPropertyTester.test(ProjectPropertyTester.java:33)
>     at org.eclipse.core.internal.expressions.Property.test(Property.java:58)
>     at org.eclipse.core.internal.expressions.TestExpression.evaluate(TestExpression.java:100)
>     at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:53)
>     at org.eclipse.core.internal.expressions.AndExpression.evaluate(AndExpression.java:31)
>     at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:53)
>     at org.eclipse.core.internal.expressions.AdaptExpression.evaluate(AdaptExpression.java:106)
>     at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:53)
>     at org.eclipse.core.internal.expressions.IterateExpression.evaluate(IterateExpression.java:199)
>     at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:53)
>     at org.eclipse.core.internal.expressions.AndExpression.evaluate(AndExpression.java:31)
>     at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:53)
>     at org.eclipse.core.internal.expressions.WithExpression.evaluate(WithExpression.java:75)
>     at org.eclipse.e4.ui.internal.workbench.ContributionsAnalyzer.isVisible(ContributionsAnalyzer.java:256)
>     at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.computeVisibility(ContributionRecord.java:166)
>     at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.updateVisibility(ContributionRecord.java:96)
>     at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.updateElementVisibility(MenuManagerRendererFilter.java:188)
>     at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.updateElementVisibility(MenuManagerRendererFilter.java:199)
>     at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerShowProcessor.showMenu(MenuManagerShowProcessor.java:230)
>     at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerShowProcessor.menuAboutToHide(MenuManagerShowProcessor.java:110)
>     at org.eclipse.jface.internal.MenuManagerEventHelper.showEventPostHelper(MenuManagerEventHelper.java:92)
>     at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:467)
>     at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:461)
>     at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:493)
>     at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:255)
>     at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)