[jbosstools-issues] [JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true

Nick Boldt (JIRA) issues at jboss.org
Mon Mar 20 09:04:00 EDT 2017


    [ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13380836#comment-13380836 ] 

Nick Boldt commented on JBIDE-24114:
------------------------------------

The PR jobs should be running unit tests, but skipping Itegration Tests with skipITests=true.

[~rhopp] can you fix the PR jobs so they run the unit tests? Why was it decided to skip unit tests when running PR checks? Simply to verify compilation? Shouldn't people be doing THAT locally before pushing the PR to github for review? [~jeffmaury] WDYT?

> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-24114
>                 URL: https://issues.jboss.org/browse/JBIDE-24114
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.4.4.AM1, 4.5.0.AM1
>            Reporter: Nick Boldt
>            Assignee: Jeff MAURY
>             Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> -               <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> +               <skipBaselineComparison>false</skipBaselineComparison>
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jbosstools-issues mailing list