[jbosstools-issues] [JBoss JIRA] (JBIDE-20028) Import wizard: cloning and import operation is executed in modal (wizard) dialog, blocks me from doing anything.

Andre Dietisheim (JIRA) issues at jboss.org
Thu Mar 23 05:21:00 EDT 2017


    [ https://issues.jboss.org/browse/JBIDE-20028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13382767#comment-13382767 ] 

Andre Dietisheim edited comment on JBIDE-20028 at 3/23/17 5:20 AM:
-------------------------------------------------------------------

If we close the wizard before we launch the import job, it's not obvious to the user that the import is being executed (especially if he at some point decided to put all  progress dialogs to the background). He only gets that if he's is closely watching to the Eclipse status bar (where the job displays it's progress) or the progress view (which might not be opened though). 

The only standard means to improve this slightly is to keep the job in the press view once it's finished and possibly have it a link which unveils further informations.
The code required for is described here: https://www.eclipse.org/articles/Article-Concurrency/jobs-api.html
{code}
     Job job = new Job("Online Reservation") {
        protected IStatus run(IProgressMonitor monitor) {
           // Make a reservation
           // ...
           setProperty(IProgressConstants.ICON_PROPERTY, getImage());
        if (isModal(this)) {
              // The progress dialog is still open so
              // just open the message
              showResults();
           } else {
           setProperty(IProgressConstants.KEEP_PROPERTY, Boolean.TRUE);
           setProperty(IProgressConstants.ACTION_PROPERTY, 
                  getReservationCompletedAction());
           }
           return Status.OK_STATUS;
        }
     };
     job.setUser(true);
     job.schedule();
{code}

non-modal notifications are lacking in the platform, efforts are ongoing: 
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=229823
* https://wiki.eclipse.org/Platform_UI/Notifications
Myling commons provide a base class that may be used to provide these: AbstractWorkbenchNotificationPopup. 


was (Author: adietish):
If we close the wizard before we launch the import job, it's not obvious to the user that the import is being executed (especially if he at some point decided to put all  progress dialogs to the background). He only gets that if he's is closely watching to the Eclipse status bar (where the job displays it's progress) or the progress view (which might not be opened though). The only standard means to improve this slightly is to keep the job in the press view once it's finished and possibly have it a link which unveils further informations.
The code required for is described here: https://www.eclipse.org/articles/Article-Concurrency/jobs-api.html
{code}
     Job job = new Job("Online Reservation") {
        protected IStatus run(IProgressMonitor monitor) {
           // Make a reservation
           // ...
           setProperty(IProgressConstants.ICON_PROPERTY, getImage());
        if (isModal(this)) {
              // The progress dialog is still open so
              // just open the message
              showResults();
           } else {
           setProperty(IProgressConstants.KEEP_PROPERTY, Boolean.TRUE);
           setProperty(IProgressConstants.ACTION_PROPERTY, 
                  getReservationCompletedAction());
           }
           return Status.OK_STATUS;
        }
     };
     job.setUser(true);
     job.schedule();
{code}

non-modal notifications are lacking in the platform, efforts are ongoing: https://bugs.eclipse.org/bugs/show_bug.cgi?id=229823
Myling commons provide a base class that may be used to provide these: AbstractWorkbenchNotificationPopup. 

> Import wizard: cloning and import operation is executed in modal (wizard) dialog, blocks me from doing anything.
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-20028
>                 URL: https://issues.jboss.org/browse/JBIDE-20028
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Andre Dietisheim
>              Labels: openshift_v3
>             Fix For: 4.5.0.AM1
>
>         Attachments: modal-dialog-blocks-me.png
>
>




--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jbosstools-issues mailing list