[jbosstools-issues] [JBoss JIRA] (JBIDE-25260) Console view is broken after entering subscription username

[Ondrej Dockal (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486136#comment-13486136 ] 

Ondrej Dockal commented on JBIDE-25260:
---------------------------------------

My 0.02 cents. 

I would like to add that entering credentials via console in GUI application (eclipse IDE) is not good practice at all, even if there is not password echoed at all.

As [~mmalina] said, there was a change in the way we were showing output of starting CDK to user. First, there was terminal view, that had possibility to pass the credentials via terminal. Then we moved to use Console View. 

> ... So under normal circumstances it doesn't come to entering credentials in the Console view. This only happens if you fail to set up your credentials properly in the cdk server adapter configuration.

Also, do not forget that this happens when one has unchecked the "Pass credentials to environment" checkbox in CDK server editor as is mentioned in Step to reproduce. Here I would advocate to remove the checkbox from server adapter as we already force the user to add the credentials via credentials dialog, we just need to check the credentials instead...

> ... To provide a better user experience, wouldn't it be possible verify the entered credentials? I understand that when entered they can still expire (for instance, changed) but verifying is just a simple POST or GET away... right?

+1. This would be a solution, wdyt [~rob.stryker] ? If we check credentials when they are entered in dialog it would be similar to what is happening in devsuite installer where user must enter proper credentials to developers.redhat.com with signed Terms and Conditions and we do not need to have user passing anything via console. 

I would like to mention, that according to https://issues.jboss.org/browse/JBIDE-25295, we cannot use upstream minishift binary under CDK 3.x server adapter after new validation was introduce in 11.1.0GA -> One cannot create a CDK server adapter with underlying minishift (upstream minishift). AND even if it was possible to create the adapter with upstream minishift in devstudio 11.0.0.GA it was not possible to properly start it. 

In case we want to provide user with option to use upstream minishift in devstudio (we should discuss it on mailing list, I believe) in future, we will be facing problem how to bypass requirement of having credentials checked against developers.redhat.com (and though, one must have an account there with signed TC) as upstream minishift does not require this (is not using rhel image) by default (but one can use flag --iso-url and then some credentials need to be passed into process - this is getting complicated). Or would we like to introduce new server adapter for upstream minishift? [~jeffmaury] [~mmalina] [~rob.stryker]?

> Console view is broken after entering subscription username
> -----------------------------------------------------------
>
>                 Key: JBIDE-25260
>                 URL: https://issues.jboss.org/browse/JBIDE-25260
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, server
>    Affects Versions: 4.5.1.Final
>            Reporter: Josef Kopriva
>            Assignee: Rob Stryker
>         Attachments: image-2017-10-17-10-38-53-270.png, with_devstudio_11.0.0.GA-0.PNG, with_devstudio_11.0.0.GA-1.PNG
>
>




--
This message was sent by Atlassian JIRA
(v7.5.0#75005)