[jbosstools-issues] [JBoss JIRA] (ERT-528) [Gtk][Webkit2] Port download functionality [EBZ#525946]

[Roland Grunberg (JIRA)]

     [ https://issues.jboss.org/browse/ERT-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roland Grunberg closed ERT-528.
-------------------------------
    Fix Version/s: Photon (4.8) M4
         Assignee: Roland Grunberg
       Resolution: Done


> [Gtk][Webkit2] Port download functionality [EBZ#525946]
> -------------------------------------------------------
>
>                 Key: ERT-528
>                 URL: https://issues.jboss.org/browse/ERT-528
>             Project: Eclipse Release Train
>          Issue Type: Task
>          Components: Platform
>            Reporter: Friendly Jira Robot
>            Assignee: Roland Grunberg
>              Labels: SWT, bzira
>             Fix For: Photon (4.8) M4
>
>
> While working on:
> Bug 514859 – [Webkit2] Verify that no webkit1-only functions are called on Webkit2. 
> I found that the 'download' functionality has a situation where Webkit2 reaches webkit1-only functions.
> See: Webkit.java
> 	webkit_download_requested(..)
> 	openDownloadWindow(..)
> ex: "webkit_download_get_suggested_filename()" is a webkit1-only function.
> This has the potential to cause a JVM crash and I don't know if download functionality actually works at the moment.
> The following needs to be done:
> 1) Guard off Webkit1 functions from ever being called by webkit2. (Patch #1).
>    (It's best that this functionality does nothing rather than cause crashes for the time being).
> 2) Write a jUnit to auto-test this functionality.
> If no jUnit can be written for this for some reason, then a test snippet should be uploaded to:
> - project:org.eclipse.swt.tests.gtk
>     folder: Bug Snippets
> 3) Implement webkit2 equivalent. 
> Note, 
> - For this you might consider testing things with a native snippet. You may find my repository with simple snippets useful. For example here is a mini-webkit browser:
> https://github.com/LeoUfimtsev/LeoGtk3/blob/master/snip_webkit_minibrowser/main.c
> - Some relevant reading material:
>   * Signals: 
>     https://developer.gnome.org/gtk-tutorial/stable/x159.html
>     https://developer.gnome.org/gobject/stable/signal.html
>     http://zetcode.com/gui/gtk2/gtkevents/



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)