[jbosstools-issues] [JBoss JIRA] (JBIDE-25118) improve errata waiver check script - add waivers for desktop-file-sanity, patches, IP v6

[Mat Booth (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472325#comment-13472325 ] 

Mat Booth commented on JBIDE-25118:
-----------------------------------

 * Desktop file sanity: Always waive
 * Elflint/Binary stripping: Usually it's because there is some unstripped or oddly built native binary in a test suite that's used to test IDE debugging functions, but seeing this error in any other case indicates a packaging error that should be fixed. I would probably leave these for manual inspection.
 * RPM requires/provides: Maybe leave these for manual inspection -- they usually happen due to changes in a package in response to a bug, I'm not sure how you'd programmatically give a sensible reason for the waiver.
 * Shell syntax: This specific case is always a false positive that could always be waived -- IMO it's probably a bug in rpmdiff mistaking tcl scripts for shell scripts.
 * Execshield: This may only be waived by the security response team, so may as well ignore it

An extra one:

 * RPM changelog: https://errata.devel.redhat.com/rpmdiff/show/182461?result_id=5039897 -- Alway waive with the reason I gave there "This change is ok because package was resynchronised with the Fedora upstream" -- it turned out to be a non-trivial exercise to merge upstream and downstream changelogs without violating some arbitrary constraint that RPM imposes about changelog entry ordering, so when importing from Fedora, the changelog is simply overwritten. I don't think anyone cares because all history is still in git anyway.

> improve errata waiver check script - add waivers for desktop-file-sanity, patches, IP v6
> ----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-25118
>                 URL: https://issues.jboss.org/browse/JBIDE-25118
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build, rpm
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>              Labels: release
>             Fix For: 4.5.1.Final
>
>
> {quote}
> It sounds like we could add these check types to my script:
>  
> * desktop-file-sanity (always waive?)
> * IP v6 (always waive using existing waiver details, eg., https://errata.devel.redhat.com/rpmdiff/show/182126?result_id=5028358
> Yep, yep.
>  
> * patches (waive if %autopatch)
> And if the only other complaints are "patch not applied" (I'm not sure if this check may throw different kinds of error){quote}
> So, the next time we have an errata with the above types of issues, I can update this script [1] to add those use cases.
> [1] https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/errataWaiveChecker.sh
> cc: [~mat.booth]



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)