[jbosstools-issues] [JBoss JIRA] (JBIDE-25118) improve errata waiver check script - add waivers for desktop-file-sanity, patches, IP v6

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472422#comment-13472422 ] 

Nick Boldt edited comment on JBIDE-25118 at 10/4/17 1:41 PM:
-------------------------------------------------------------

This commit [1] will:
* add support for never-waived items, 
* add support for more types of auto-waived items, 
* provide a custom reason for changelog issues, 
* add -fn flag to continue checking waivers if one test (eg., rpm install for symlinks) fails, 
* fix support for running against a single errata page (which will still find its children), 
* implement a check to prevent re-waiving an already waived item,
* ignore waived items when parsing a page for types of things to check (based on the green already-waived colour, eg for *File list* items),
* default to checking all the waiver types w/o needing the -p flag

[1] https://github.com/jbosstools/jbosstools-build-ci/commit/99ba1cb720d5f6105e0f7feb9d78239a77a96a2c




was (Author: nickboldt):
This commit [1] will:
* add support for never-waived items, 
* add support for more types of auto-waived items, 
* provide a custom reason for changelog issues, 
* add -fn flag to continue checking waivers if one test (eg., rpm install for symlinks) fails, 
* fix support for running against a single errata page (which will still find its children), 
* implement a check to prevent re-waiving an already waived item,
* ignore waived items when parsing a page for types of things to check (based on the green already-waived colour, eg for *File list* items)

[1] https://github.com/jbosstools/jbosstools-build-ci/commit/99ba1cb720d5f6105e0f7feb9d78239a77a96a2c



> improve errata waiver check script - add waivers for desktop-file-sanity, patches, IP v6
> ----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-25118
>                 URL: https://issues.jboss.org/browse/JBIDE-25118
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build, rpm
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>              Labels: release
>             Fix For: 4.5.1.Final
>
>
> {quote}
> It sounds like we could add these check types to my script:
>  
> * desktop-file-sanity (always waive?)
> * IP v6 (always waive using existing waiver details, eg., https://errata.devel.redhat.com/rpmdiff/show/182126?result_id=5028358
> Yep, yep.
>  
> * patches (waive if %autopatch)
> And if the only other complaints are "patch not applied" (I'm not sure if this check may throw different kinds of error){quote}
> So, the next time we have an errata with the above types of issues, I can update this script [1] to add those use cases.
> [1] https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/errataWaiveChecker.sh
> cc: [~mat.booth]



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)