[jbosstools-issues] [JBoss JIRA] (JBIDE-25167) CDK 3.2+ adapter is created automatically even if I have CDK 3.1.1 installed

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474950#comment-13474950 ] 

Rob Stryker commented on JBIDE-25167:
-------------------------------------

We already do check for versions.  See https://github.com/jbosstools/jbosstools-openshift/blob/de7d0c56d14d1fbbbf51c8b9ce4d1bb89ce422e5/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/detection/CDK3RuntimeDetector.java#L113

This gets the version. Next, one of the two adapters will decide whether they can handle the version. 

1) The normal cdk3 adapter logic will match on any version string that starts with 3.0 or 3.1.

https://github.com/jbosstools/jbosstools-openshift/blob/de7d0c56d14d1fbbbf51c8b9ce4d1bb89ce422e5/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/detection/CDK3RuntimeDetector.java#L60

2) The cdk32 adapter logic will match on anything that begins with 3. and does NOT begin with 3.0 or 3.1.  Basically, it'll match on [3.2, 4.0). 

https://github.com/jbosstools/jbosstools-openshift/blob/de7d0c56d14d1fbbbf51c8b9ce4d1bb89ce422e5/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/detection/CDK32RuntimeDetector.java#L19

> CDK 3.2+ adapter is created automatically even if I have CDK 3.1.1 installed
> ----------------------------------------------------------------------------
>
>                 Key: JBIDE-25167
>                 URL: https://issues.jboss.org/browse/JBIDE-25167
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.5.1.AM3
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>            Priority: Critical
>
> I installed devstudio 11.1.0.AM3 B1225 and when I launched it there was a cdk server adapter already set up. That's completely normal. But what's wrong is that it's the new 3.2+ adapter whereas what I have actually installed in ~/.minishift is version 3.1.1.
> The runtime detection should be able to detect the version in ~/.minishift/cdk and return a match only if the version is compatible with the given adapter.
> [~jkopriva] says cdk 3.1.1 cannot be launched with cdk 3.2+ adapter. I cannot really check that myself because my server adapter doesn't have minishift binary set up by default and you validate the version in the server editor, so I can't use 3.1.1 with the 3.2+ adapter.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)