[jbosstools-issues] [JBoss JIRA] (JBIDE-25225) OSIO login: error when the login window is closed by the user

[Jeff MAURY (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476249#comment-13476249 ] 

Jeff MAURY commented on JBIDE-25225:
------------------------------------

This was done that way because the base service that is exposed to third parties plugins (and the connect button is an example) just call getToken to get a token and if we need to login because there is no account or tokens are not valid, and if the user closes the login dialog then we report an exception and in that case the LoginException is raised to indicate why the getToken failed

> OSIO login: error when the login window is closed by the user
> -------------------------------------------------------------
>
>                 Key: JBIDE-25225
>                 URL: https://issues.jboss.org/browse/JBIDE-25225
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.5.1.Final
>            Reporter: Martin Malina
>             Fix For: 4.5.1.Final
>
>         Attachments: osio-error.png
>
>
> I tested the OSIO login feature and it works pretty well. But one thing should be fixed I think. When you click the icon and the login browser window is opened and then you change your mind and click Close on the window, you're given an error:
> Error login to cluster OpenShift.io
> !osio-error.png!
> I think in the case of the user closing the window there shouldn't be an error like this.
> I understand that we do need some form of indication if the username is correct (so the webpage accepts it), but the login in devstudio fails somehow. In this case it is correct to display an error.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)