[jbosstools-issues] [JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill code is reviewed

[Dmitrii Bocharov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476474#comment-13476474 ] 

Dmitrii Bocharov commented on JBIDE-24671:
------------------------------------------

[~nickboldt] yes, i think we can give the bot admin access. But how will it work? Will we write a special comment to merge via the bot?

Also i created a separate JBIDE-25221 yesterday and linked it to the JBIDE-24439, as you told me in mattermost. Should we close it not?

> [jbosstools-openshift] Block PRs for merge untill code is reviewed
> ------------------------------------------------------------------
>
>                 Key: JBIDE-24671
>                 URL: https://issues.jboss.org/browse/JBIDE-24671
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: openshift
>    Affects Versions: 4.5.1.AM1
>            Reporter: Nick Boldt
>            Assignee: Dmitrii Bocharov
>             Fix For: 4.5.1.Final
>
>         Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked: 
> {quote}
>  if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I  have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)