[jbosstools-issues] [JBoss JIRA] (JBIDE-25228) target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477113#comment-13477113 ] 

Mickael Istria edited comment on JBIDE-25228 at 10/13/17 12:23 PM:
-------------------------------------------------------------------

;../So
{code:java}tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), unit.getVersion());{code}
is most likely the cause of the issue. It should be something like
{code:java}
  String version = unit.getVersion();
  if (version == null || version.isEmpty()) {
    version = "0.0.0";
  } else if (!"0.0.0".equals(unit.getVersion()) {
    version = '[' + unit.getVersion() + ',' + unit.getVersion() + ']';
  }
  tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), version);
{code}
to make sure we lock to the resolved version and not to a range (just "1.6.0.xyz" actually means [1.6.0.xyz, 2.0.0) to p2 resolver IIRC)


was (Author: mickael_istria):
;../So
{code}tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), unit.getVersion());{code}
is most likely the cause of the issue. It should be something like
{code}
  String version = unit.getVersion();
  if (version == null || version.isEmpty()) {
    version = "0.0.0";
  } else if ("0.0.0.equals(unit.getVersion()) {
    version = '[' + unit.getVersion() + ',' + unit.getVersion() + ']';
  }
  tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), version);
{code}
to make sure we lock to the resolved version and not to a range (just "1.6.0.xyz" actually means [1.6.0.xyz, 2.0.0) to p2 resolver IIRC)

> target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
> --------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-25228
>                 URL: https://issues.jboss.org/browse/JBIDE-25228
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: target-platform
>    Affects Versions: 4.5.1.Final
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Blocker
>             Fix For: 4.5.1.Final
>
>
> With these recent changes [0], [1], target platform resolution is no longer able to fetch more than one version of an IU. 
> We need apache.commons.codec 1.6.0.v201305230611, per the .target file [2], but only org.apache.commons.codec_1.9.0.v20170208-1614.jar is found in the update site [3], so the job [4] cannot perform an installation and validation of the TP fails.
> Is there a setting I can pass in to make TargetToRepo more greedy about pulling multiple versions of IUs? 
> Note too that I was having problems last night getting the fix-version mojo to properly find and update the versions of WTP in the new 3.9.1a site, even when explicitly setting 0.0.0 to force it to search and update. Seems the target platform resolver will only pull the latest version of an IU, rather than an older one (a few WTP features have gone backwards in their timestamp). But it could also not resolve a version change from 3.3.600 [5] to 3.3.601 [6], so I had to update the version manually.
> [0] https://github.com/jbosstools/jbosstools-maven-plugins/commit/2b724eceadb1223d110901485d79a8c07b46a4b8?w=1#diff-7bbc7ab4e5cb45cc948dc1770d7a1a0e
> [1] https://github.com/jbosstools/jbosstools-maven-plugins/commit/ac4e492fab41af1cc0f1959fcce7385a8a07bd5a
> [2] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbosstools/multiple/jbosstools-multiple.target#L51
> [3] http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.71.0.Final-SNAPSHOT/REPO/plugins/
> [4] https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoolstargetplatform-4.71.x/jdk=openjdk-1.8,label_exp=rhel7-devstudio-releng/30/console
> [5] https://github.com/jbosstools/jbosstools-target-platforms/blob/14ec465a9b83a632daecf50d8ef9ac3e9c7b32e2/jbosstools/multiple/jbosstools-multiple.target#L482
> [6] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbosstools/multiple/jbosstools-multiple.target#L482



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)