[jbosstools-issues] [JBoss JIRA] (JBIDE-25091) Edit resource limits wizard: Duplicate value "MiB" in Memory Limit & Request

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479462#comment-13479462 ] 

Andre Dietisheim edited comment on JBIDE-25091 at 10/19/17 11:29 AM:
---------------------------------------------------------------------

The reason for this is that the code translates units in the model to labels in the combo. It translates the following units in the model (resource)
{code}
    public static final String[] MEMORY_SUFFIXES = {"M", "G", "Mi", "Gi", ""};
{code}

to the following labels in the combo:
{code}
    public static final String[] MEMORY_SUFFIXES_LABELS = {"MB", "GB", "MiB", "GiB", "MiB"};
{code}

In other terms, a missing unit in the resource model gets displayed as "MiB" in the combo, thus the duplication of units in the combo.


was (Author: adietish):
The reason for this behavious is that the code does translate units. It translates the following units in the model
{code}
    public static final String[] MEMORY_SUFFIXES = {"M", "G", "Mi", "Gi", ""};
{code}

to the following labels in the combo:
{code}
    public static final String[] MEMORY_SUFFIXES_LABELS = {"MB", "GB", "MiB", "GiB", "MiB"};
{code}

in other terms, a missing unit in the resource model gets displayed as "MiB" in the combo, thus the duplication of units in the combo.

> Edit resource limits wizard: Duplicate value "MiB" in Memory Limit & Request
> ----------------------------------------------------------------------------
>
>                 Key: JBIDE-25091
>                 URL: https://issues.jboss.org/browse/JBIDE-25091
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.5.1.AM2
>            Reporter: Josef Kopriva
>            Priority: Minor
>              Labels: edit_resource_limits_wizard, openshift_v3
>             Fix For: 4.5.x
>
>         Attachments: edit-resource-limits.png, image-2017-09-22-13-02-35-216.png
>
>
> When editing memory settings in dialog "Edit resource limits", there is a duplicate value MiB in the Combos for Memory > "Request" and Memory > "Limit":
>  !edit-resource-limits.png! 



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)