[jbosstools-issues] [JBoss JIRA] (JBIDE-25091) Edit resource limits wizard: setting memory resource limits errors if you use the 2 duplicate MiB entries

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480468#comment-13480468 ] 

Andre Dietisheim edited comment on JBIDE-25091 at 10/23/17 8:30 AM:
--------------------------------------------------------------------

[~dbocharov] the empty unit starts to appear in the combo in the web-ui if you manually (ex. via editing the dc in Eclipse) and set a value without unit (which in case of memory is in bytes):

{code}
"resources":{  
                     "limits":{  
                        "memory":"512Mi"
                     },
                     "requests":{  
                        "memory":"5"
                     }
                  },
{code}
which results in the following in the web-ui:
!resource-limits-web-console.png!


was (Author: adietish):
[~dbocharov] the empty unit starts to appear in the combo in the web-ui if you manually (ex. via editing the dc in Eclipse) and set a value without unit (which in case of memory is in bytes):

{code}
"resources":{  
                     "requests":{  
                        "memory":"5"
                     }
{code}
!resource-limits-web-console.png!

> Edit resource limits wizard: setting memory resource limits errors if you use the 2 duplicate MiB entries
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-25091
>                 URL: https://issues.jboss.org/browse/JBIDE-25091
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.5.1.AM2
>            Reporter: Josef Kopriva
>            Assignee: Andre Dietisheim
>              Labels: edit_resource_limits_wizard, openshift_v3
>             Fix For: 4.5.1.Final
>
>         Attachments: edit-resource-limits.png, error-limit-must-be-equal-or-greater-than-request.png, image-2017-09-22-13-02-35-216.png, memory-limit-limit.png, memory-request-limit.png, request-resource-limit-combo.png, resource-limits-web-console.png, units.png
>
>
> When editing memory settings in dialog "Edit resource limits", there is a duplicate value MiB in the Combos for Memory > "Request" and Memory > "Limit":
>  !edit-resource-limits.png! 
> You can have setting the limits error inexplicably in the following way:
> # ASSERT: make sure that you have an application with a service, replication controller/deployment config running in OpenShift (ex. create one using the nodejs-mongo-persistent template)
> # EXEC: in OpenShift explorer: select the service for your application and pick "Edit resource limit" in the context menu for it
> # ASSERT: "Edit resource limit" dialog shows up
> # EXEC: set Memory > Request to 128 and pick the 1st MiB entry in the combo
>  !memory-request-limit.png! 
> # EXEC: set Memory > Limit to 512 and pick the 2nd MiB entry in the combo
>  !memory-limit-limit.png!
> # EXEC: "Finish" the wizard
> Result:
> The wizard errors telling you that the limit must be equal or greater than the request:
>  !error-limit-must-be-equal-or-greater-than-request.png! 
> In the Eclipse log you find the following:
> {code}
> com.openshift.restclient.OpenShiftException: Exception trying to PUT https://192.168.64.12:8443/oapi/v1/namespaces/nodejs/deploymentconfigs/nodejs-mongo-persistent response code: 422 DeploymentConfig "nodejs-mongo-persistent" is invalid: spec.template.spec.containers[0].resources.limits: Invalid value: "512": must be greater than or equal to memory request
> 	at com.openshift.internal.restclient.okhttp.ResponseCodeInterceptor.createOpenShiftException(ResponseCodeInterceptor.java:114)
> 	at com.openshift.internal.restclient.okhttp.ResponseCodeInterceptor.intercept(ResponseCodeInterceptor.java:65)
> 	at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:190)
> 	at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:163)
> 	at okhttp3.RealCall.execute(RealCall.java:57)
> 	at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:258)
> 	at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:222)
> 	at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:210)
> 	at com.openshift.internal.restclient.DefaultClient.update(DefaultClient.java:316)
> 	at org.jboss.tools.openshift.core.connection.Connection.updateResource(Connection.java:451)
> 	at org.jboss.tools.openshift.internal.ui.wizard.common.EditResourceLimitsHandler$EditResourceLimitsWizard$1.run(EditResourceLimitsHandler.java:117)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {code} 



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)