[jbosstools-issues] [JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459930#comment-13459930 ] 

Nick Boldt edited comment on JBIDE-24968 at 9/6/17 7:30 PM:
------------------------------------------------------------

Seems the root cause here is that we're assigning the value of *skipTests* (eg., true) to *skipRequirements* [0], and in the parent pom, *skipRequirements* is used to determine if maven-download-plugin:1.1 and download-maven-plugin:1.2+ are going to fire or be skipped [1].

[0] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L63
[1] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L637-L655

So, in https://github.com/jbosstools/jbosstools-base/pull/592/files I've set the call to download-maven-plugin:1.3 to never be skipped, since it's not fetching a TEST REQUIREMENT (eg., server runtimes) but a bit of the foundation.core plugin's source code.

Thanks to Rob for nagging me until I dug into this. :)




was (Author: nickboldt):
Seems the root cause here is that we're assigning the value of *skipTests* (eg., true) to *skipRequirements*, and in the parent pom, *skipRequirements* is used to determine if maven-download-plugin:1.1 and download-maven-plugin:1.2+ are going to fire or be skipped.

So, in https://github.com/jbosstools/jbosstools-base/pull/592/files I've set the call to download-maven-plugin to never be skipped, since it's not fetching a REQUIREMENT but a bit of plugin source code.

Thanks to Rob for nagging me until I dug into this. :)



> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
>                 Key: JBIDE-24968
>                 URL: https://issues.jboss.org/browse/JBIDE-24968
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 4.5.1.AM1
>            Reporter: Aurélien Pupier
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> 	at java.util.Properties$LineReader.readLine(Properties.java:434)
> 	at java.util.Properties.load0(Properties.java:353)
> 	at java.util.Properties.load(Properties.java:341)
> 	at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> 	at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> 	at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> 	at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> 	at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)