[jbosstools-issues] [JBoss JIRA] (JBIDE-24991) Improve server port offset detection by inspecting configured system properties

[Vsevolod Golovanov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-24991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464197#comment-13464197 ] 

Vsevolod Golovanov commented on JBIDE-24991:
--------------------------------------------

[~rob.stryker], no, I'm not touching the launch config in Eclipse. The system property is defined in the one and only standalone.xml, on the server:
{code}<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<server xmlns="urn:jboss:domain:4.0">
    <extensions>
        <extension module="org.jboss.as.deployment-scanner"/>
    <extension module="org.jboss.as.clustering.infinispan"/>
    <system-properties>  
        <property name="jboss.socket.binding.port-offset" value="10"/>
		...
    </system-properties> 
...
    <socket-binding-group default-interface="public" name="standard-sockets" port-offset="${jboss.socket.binding.port-offset:0}">
...
    </socket-binding-group>
</server>
{code}
JBT already looks at the {{port-offset="$\{jboss.socket.binding.port-offset:0\}"}} and picks up this {{0}}.
I propose that JBT also sees the {{jboss.socket.binding.port-offset}} part and checks system-properties in the same standalone.xml.

> Improve server port offset detection by inspecting configured system properties
> -------------------------------------------------------------------------------
>
>                 Key: JBIDE-24991
>                 URL: https://issues.jboss.org/browse/JBIDE-24991
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: server
>    Affects Versions: 4.5.0.Final
>         Environment: JBDS11, WF10
>            Reporter: Vsevolod Golovanov
>            Assignee: Rob Stryker
>             Fix For: 4.5.x
>
>
> The default Wildfly standalone.xml config has port offset configured like this: 
> {code}
> <socket-binding-group ... port-offset="${jboss.socket.binding.port-offset:0}">
> {code}
> With the way our configuration process is set up we don't change that. Instead we add a system property to the same config file:
> {code}
> <system-properties>
>     <property name="jboss.socket.binding.port-offset" value="10"/>
> </system-properties>
> {code}
> The problem is JBoss Tools doesn't detect this currently. It could be improved to inspect the port-offset attribute and find the corresponding system property value.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)